From: Eli Zaretskii <eliz@gnu.org>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: Buffer size limitation in insdel.c
Date: Thu, 23 Sep 2010 15:22:09 +0200 [thread overview]
Message-ID: <83hbhgvblq.fsf@gnu.org> (raw)
In-Reply-To: <m3wrqcocdg.fsf@quimbies.gnus.org>
> From: Lars Magne Ingebrigtsen <larsi@gnus.org>
> Date: Thu, 23 Sep 2010 14:47:23 +0200
>
> A few general questions:
>
> dispnew.c:783: warning: conversion to 'int' from 'Lisp_Object' may alter its value
>
> matrix->window_left_col = WINDOW_LEFT_EDGE_COL (w);
>
> What's the right fix here? make window_left_col EMACS_INT, and slap an
> XINT around the WINDOW_LEFT_EDGE_COL?
I don't see this warning with "gcc (GCC) 4.2.4 (Ubuntu 4.2.4-1ubuntu4)".
And I don't see how you could possibly get it, since
window_left_edge_col is an int, whereas WINDOW_LEFT_EDGE_COL is
defined like this:
#define WINDOW_LEFT_EDGE_COL(W) \
(XFASTINT ((W)->left_col))
So it already extracts the integer from a Lisp_Object. What am I
missing?
> dispnew.c:2178: warning: conversion to 'long unsigned int' from 'short int' may change the sign of the result
>
> size_t nbytes = from->used[TEXT_AREA] * sizeof (struct glyph);
Something like
size_t nbytes;
if (from->used[TEXT_AREA] > 0)
nbytes = from->used[TEXT_AREA] * sizeof (struct glyph);
else
nbytes = 0;
Or just leave it alone, it obviously isn't in the way of using large
buffers on 64-bit hosts.
And btw, I don't see that warning, either.
next prev parent reply other threads:[~2010-09-23 13:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 12:06 Buffer size limitation in insdel.c Eli Zaretskii
2010-09-22 12:12 ` Lars Magne Ingebrigtsen
2010-09-22 15:20 ` Eli Zaretskii
2010-09-22 12:16 ` David Kastrup
2010-09-23 0:06 ` Stefan Monnier
2010-09-23 0:58 ` Richard Stallman
2010-09-23 7:55 ` Eli Zaretskii
2010-09-23 9:23 ` Leo
2010-09-23 9:30 ` Eli Zaretskii
2010-09-23 10:59 ` Lars Magne Ingebrigtsen
2010-09-23 12:15 ` Eli Zaretskii
2010-09-23 12:18 ` Lars Magne Ingebrigtsen
2010-09-23 12:47 ` Lars Magne Ingebrigtsen
2010-09-23 13:12 ` Andreas Schwab
2010-09-23 13:22 ` Eli Zaretskii [this message]
2010-09-23 13:37 ` Lars Magne Ingebrigtsen
2010-09-23 14:13 ` Eli Zaretskii
2010-09-23 14:21 ` Lars Magne Ingebrigtsen
2010-09-23 14:31 ` Lars Magne Ingebrigtsen
2010-09-23 14:41 ` Eli Zaretskii
2010-09-23 14:49 ` Lars Magne Ingebrigtsen
2010-09-23 15:08 ` Lars Magne Ingebrigtsen
2010-09-23 18:56 ` Eli Zaretskii
2010-09-23 19:02 ` Lars Magne Ingebrigtsen
2010-09-23 19:22 ` Eli Zaretskii
2010-09-24 14:09 ` Richard Stallman
2010-09-24 14:28 ` Eli Zaretskii
2010-09-24 14:38 ` Lars Magne Ingebrigtsen
2010-09-25 13:55 ` Eli Zaretskii
2010-09-25 16:26 ` Lars Magne Ingebrigtsen
2010-09-25 16:38 ` Lars Magne Ingebrigtsen
2010-09-25 9:40 ` Richard Stallman
2010-09-25 10:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83hbhgvblq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).