From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: 5x5 Arithmetic solver Date: Sat, 21 May 2011 10:49:27 +0300 Message-ID: <83hb8ofq7s.fsf@gnu.org> References: <80r57s4j82.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: dough.gmane.org 1305964181 9859 80.91.229.12 (21 May 2011 07:49:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 21 May 2011 07:49:41 +0000 (UTC) Cc: vincent.b.1@hotmail.fr, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Vincent =?iso-8859-1?Q?Bela=EFche?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 21 09:49:34 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QNgwH-0006HV-Vf for ged-emacs-devel@m.gmane.org; Sat, 21 May 2011 09:49:34 +0200 Original-Received: from localhost ([::1]:34424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNgwH-0004EV-F7 for ged-emacs-devel@m.gmane.org; Sat, 21 May 2011 03:49:33 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:59718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNgwF-0004EP-CB for emacs-devel@gnu.org; Sat, 21 May 2011 03:49:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QNgwE-0004hp-Ej for emacs-devel@gnu.org; Sat, 21 May 2011 03:49:31 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:54092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNgwE-0004he-86 for emacs-devel@gnu.org; Sat, 21 May 2011 03:49:30 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LLJ00200CBAL800@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sat, 21 May 2011 10:49:28 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.124.254.13]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LLJ002O7CEB8Q40@a-mtaout20.012.net.il>; Sat, 21 May 2011 10:49:28 +0300 (IDT) In-reply-to: <80r57s4j82.fsf@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139569 Archived-At: > From: Vincent Bela=EFche =20 > Date: Sat, 21 May 2011 09:15:57 +0200 > Cc: Vincent Bela=EFche >=20 > >- Please capitalize your comments and terminate them with a "." or= some > > other appropriate punctuation. > [...] > For all the remaining comments I have done it Did you send the corrected version? Because I still see non-capitalized comments that don't fall under any of your exceptions= : > +=09 ;; transfer matrix is the 25x25 matrix applied everytime a fli= p is > +=09 ;; carried out where a flip is defined by a 25x1 Dirac vector = --- ie > +=09 ;; all zeros but 1 in the position that is flipped. > [...] > +=09 ;; by construction ctransferm-:-2 =3D 0, so ctransferm-1-2 = =3D 0 > +=09 ;; and ctransferm-2-2 =3D 0 > [...] > +=09 ;; any cx-2 can do, so there are 2^transferm-kernel-size solut= ions > +=09 (solution-list > +=09 ;; within solution-list each element is a cons cell (HW . SOL= ) where > +=09 ;; HW is the Hamming weight of solution, and SOL is the solut= ion in > +=09 ;; the form of a grid. > [...] > +=09 ;; sort solutions according to respective Hamming weight By the way, please leave two spaces after the period that ends a sentence. This is our convention in any text we write in Emacs, including comments, doc strings, and manuals. > >- we need a ChangeLog entry. >=20 > Here it is: >=20 > -------------------------------------------------------------------= ---- > 2011-05-21 Vincent Bela=EFche >=20 > =09* play/5x5.el: Add an arithmetic solver to suggest positions to > =09click on. > -------------------------------------------------------------------= ---- No, that's not enough. What you've written is the summary line, but the ChangeLog also needs the details: which functions and variables were added or deleted, which were modified and how, etc. Like this: =09(5x5-solver-output): New defvar. =09(5x5-local-variables): New defconst. =09(5x5-mode): Make all variables in 5x5-local-variables local. =09(5x5): Set 5x5-grid-size only if SIZE is non-negative. etc. You can see plenty of examples of the exact style in the ChangeLog files. Please also spell-check your comments and doc strings, there are a fe= w non-English words I spotted here and there. Thanks.