From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [RFC] using "optimizaiton 1"
Date: Sat, 15 Dec 2012 11:57:34 +0200 [thread overview]
Message-ID: <83hannmycx.fsf@gnu.org> (raw)
In-Reply-To: <50CB5820.3060909@yandex.ru>
> Date: Fri, 14 Dec 2012 20:47:28 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
> CC: emacs-devel@gnu.org
>
> On 12/14/2012 06:15 PM, Eli Zaretskii wrote:
>
> IOW, I suspect that this code:
>
> 13248 /* If showing the region, and mark has changed, we must redisplay
> 13249 the whole window. The assignment to this_line_start_pos prevents
> 13250 the optimization directly below this if-statement. */
> 13251 if (((!NILP (Vtransient_mark_mode)
> 13252 && !NILP (BVAR (XBUFFER (w->buffer), mark_active)))
> 13253 != !NILP (w->region_showing))
> 13254 || (!NILP (w->region_showing)
> 13255 && !EQ (w->region_showing,
> 13256 Fmarker_position (BVAR (XBUFFER (w->buffer), mark)))))
> 13257 CHARPOS (this_line_start_pos) = 0;
>
> is obsolete (heh, it's there since 1993). If showing the region, and
> both PT and mark are on the same line
How do you conclude that both point and mark are on the same line?
The above just tests whether mark has changed, it doesn't say anything
about point, AFAICT.
In any case, is this situation frequent enough to be worth optimizing?
prev parent reply other threads:[~2012-12-15 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 14:10 [RFC] using "optimizaiton 1" Dmitry Antipov
2012-12-14 14:15 ` Eli Zaretskii
2012-12-14 16:47 ` Dmitry Antipov
2012-12-15 9:57 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83hannmycx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).