From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r116230: Fix bug #16558 with w32-shell-execute on remote file names.
Date: Thu, 06 Feb 2014 13:47:25 +0200 [thread overview]
Message-ID: <83ha8czcmq.fsf@gnu.org> (raw)
In-Reply-To: <jwv1tzhfd0h.fsf-monnier+emacsdiffs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Wed, 05 Feb 2014 16:53:51 -0500
>
> >> That look reasonable (and didn't involve any remote connection or any
> >> such problem).
> > How is the 2nd one reasonable?
>
> Why shouldn't it be? It's in a context where url-handler-mode is
> deactivated, so Emacs has no reason to presume that it's a URL.
>
> > It means we will pass it through
> > expand-file-name,
>
> Which might be the right thing to do.
>
> > (expand-file-name "http://foo.com/wherever/index.html")
> > => "d:/gnu/bzr/emacs/trunk/http:/foo.com/wherever/index.html"
>
> If d:/gnu/bzr/emacs/trunk/http:/foo.com/wherever/ exists, then I'd argue
> it was the right thing to do.
We are talking about Windows, where such file names are impossible.
> >> The connection between the core problem of detecting the case of
> >> (w32-shell-execute "dir/file") and the check of file-name-handlers is
> >> really non-obvious.
> > If DOCUMENT doesn't have file handlers, it is more likely to be a
> > local file or directory.
>
> The correlation is weak. I don't think this heuristic is worth much if
> anything in this context.
Even a weak correlation is something. And this was introduced in
response to a bug report that clearly had to do with a file which did
have a handler.
> > I don't see how your proposal is simpler than what's already there, or
> > better, sorry.
>
> It's better because all the checks are *directly* related to the problem
> at hand: detecting non-absolute file names which include
> a directory component.
>
> If you only care about simpler, then we can just remove the
> file-name-handler check and only rely on the faccess check.
> That should work just as well.
The existing code also works, and is extensively commented to describe
the problem it solves. I would like to refrain from unnecessary
changes, certainly during the freeze, unless you insist.
next prev parent reply other threads:[~2014-02-06 11:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1W9Wnn-0004N6-IY@vcs.savannah.gnu.org>
2014-02-01 19:26 ` [Emacs-diffs] trunk r116230: Fix bug #16558 with w32-shell-execute on remote file names Stefan Monnier
2014-02-01 19:58 ` Eli Zaretskii
2014-02-02 0:44 ` Stefan Monnier
2014-02-02 3:43 ` Eli Zaretskii
2014-02-02 15:06 ` Stefan Monnier
2014-02-02 15:54 ` Eli Zaretskii
2014-02-03 2:33 ` Stefan Monnier
2014-02-03 4:12 ` David Kastrup
2014-02-03 5:57 ` Eli Zaretskii
2014-02-03 5:55 ` Eli Zaretskii
2014-02-03 14:06 ` Stefan Monnier
2014-02-03 16:17 ` Eli Zaretskii
2014-02-04 3:39 ` Stefan Monnier
2014-02-04 16:31 ` Eli Zaretskii
2014-02-04 20:35 ` Stefan Monnier
2014-02-04 21:01 ` Eli Zaretskii
2014-02-05 2:38 ` Stefan Monnier
2014-02-05 3:56 ` Eli Zaretskii
2014-02-05 14:10 ` Stefan Monnier
2014-02-05 16:07 ` Eli Zaretskii
2014-02-05 19:09 ` Stefan Monnier
2014-02-05 19:56 ` Eli Zaretskii
2014-02-05 21:53 ` Stefan Monnier
2014-02-06 11:47 ` Eli Zaretskii [this message]
2014-02-02 7:45 ` Stefan-W. Hahn
2014-02-05 17:21 grischka
2014-02-05 17:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ha8czcmq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).