unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Trunk r117932 build failure on mingw64
@ 2014-09-24  9:28 Andy Moreton
  2014-09-24 10:10 ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Andy Moreton @ 2014-09-24  9:28 UTC (permalink / raw)
  To: emacs-devel

Hi,

The changes in r117932 break the mingw64 64bit build:

gcc -std=gnu99  -c -mtune=generic   -DUSE_CRT_DLL=1 -I /c/emacs/src/emacs/trunk/obj-mingw64/../nt/inc -Demacs  -I. -I../../src -I../lib -I../../lib  -mtune=generic    -pthread -mms-bitfields -I/mingw64/include/librsvg-2.0 -I/mingw64/include/gdk-pixbuf-2.0 -I/mingw64/include/libpng16 -I/mingw64/include/cairo -I/mingw64/include/glib-2.0 -I/mingw64/lib/glib-2.0/include -I/mingw64/include/pixman-1 -I/mingw64/include -I/mingw64/include/freetype2 -I/mingw64/include -I/mingw64/include/libpng16 -I/mingw64/include/harfbuzz -I/mingw64/include -I/mingw64/include/freetype2 -I/mingw64/include/libpng16    -I/mingw64/include/libxml2           -MMD -MF deps/dispnew.d -MP -I/mingw64/include -I/mingw64/include/p11-kit-1 -I/mingw64/include     -O0 -g3  ../../src/dispnew.c
In file included from ../../src/lisp.h:33:0,
                 from ../../src/dispnew.c:26:
../../lib/verify.h:207:21: error: static assertion failed: "verify (sizeof (Time) == sizeof (ptrdiff_t))"
 # define _GL_VERIFY _Static_assert
                     ^
../../lib/verify.h:251:19: note: in expansion of macro '_GL_VERIFY'
 #define verify(R) _GL_VERIFY (R, "verify (" #R ")")
                   ^
../../src/termhooks.h:292:1: note: in expansion of macro 'verify'
 verify (sizeof (Time) == sizeof (ptrdiff_t));
 ^




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Trunk r117932 build failure on mingw64
  2014-09-24  9:28 Trunk r117932 build failure on mingw64 Andy Moreton
@ 2014-09-24 10:10 ` Eli Zaretskii
  2014-09-24 10:16   ` Eli Zaretskii
  2014-09-24 13:34   ` cg
  0 siblings, 2 replies; 6+ messages in thread
From: Eli Zaretskii @ 2014-09-24 10:10 UTC (permalink / raw)
  To: Andy Moreton; +Cc: emacs-devel

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Wed, 24 Sep 2014 10:28:39 +0100
> 
> The changes in r117932 break the mingw64 64bit build:

It was already broken, you just didn't know that.  We were assigning a
64-bit value to a 32-bit struct member.  The static assertion added by
Dmitry simply made that problem stare in our face.

> gcc -std=gnu99  -c -mtune=generic   -DUSE_CRT_DLL=1 -I /c/emacs/src/emacs/trunk/obj-mingw64/../nt/inc -Demacs  -I. -I../../src -I../lib -I../../lib  -mtune=generic    -pthread -mms-bitfields -I/mingw64/include/librsvg-2.0 -I/mingw64/include/gdk-pixbuf-2.0 -I/mingw64/include/libpng16 -I/mingw64/include/cairo -I/mingw64/include/glib-2.0 -I/mingw64/lib/glib-2.0/include -I/mingw64/include/pixman-1 -I/mingw64/include -I/mingw64/include/freetype2 -I/mingw64/include -I/mingw64/include/libpng16 -I/mingw64/include/harfbuzz -I/mingw64/include -I/mingw64/include/freetype2 -I/mingw64/include/libpng16    -I/mingw64/include/libxml2           -MMD -MF deps/dispnew.d -MP -I/mingw64/include -I/mingw64/include/p11-kit-1 -I/mingw64/include     -O0 -g3  ../../src/dispnew.c
> In file included from ../../src/lisp.h:33:0,
>                  from ../../src/dispnew.c:26:
> ../../lib/verify.h:207:21: error: static assertion failed: "verify (sizeof (Time) == sizeof (ptrdiff_t))"
>  # define _GL_VERIFY _Static_assert
>                      ^
> ../../lib/verify.h:251:19: note: in expansion of macro '_GL_VERIFY'
>  #define verify(R) _GL_VERIFY (R, "verify (" #R ")")
>                    ^
> ../../src/termhooks.h:292:1: note: in expansion of macro 'verify'
>  verify (sizeof (Time) == sizeof (ptrdiff_t));
>  ^

Fixed in trunk revision 117933.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Trunk r117932 build failure on mingw64
  2014-09-24 10:10 ` Eli Zaretskii
@ 2014-09-24 10:16   ` Eli Zaretskii
  2014-09-24 13:34   ` cg
  1 sibling, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2014-09-24 10:16 UTC (permalink / raw)
  To: andrewjmoreton; +Cc: emacs-devel

> Date: Wed, 24 Sep 2014 13:10:10 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> > From: Andy Moreton <andrewjmoreton@gmail.com>
> > Date: Wed, 24 Sep 2014 10:28:39 +0100
> > 
> > The changes in r117932 break the mingw64 64bit build:
> 
> It was already broken, you just didn't know that.  We were assigning a
> 64-bit value to a 32-bit struct member.  The static assertion added by
> Dmitry simply made that problem stare in our face.

Correction: the change that caused this assignment was also part of
r117932.  So you were right.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Trunk r117932 build failure on mingw64
  2014-09-24 10:10 ` Eli Zaretskii
  2014-09-24 10:16   ` Eli Zaretskii
@ 2014-09-24 13:34   ` cg
  2014-09-24 14:41     ` Eli Zaretskii
  1 sibling, 1 reply; 6+ messages in thread
From: cg @ 2014-09-24 13:34 UTC (permalink / raw)
  To: emacs-devel

On 9/24/2014 6:10 PM, Eli Zaretskii wrote:
>
> Fixed in trunk revision 117933.
>


Looks like it is still broken at the moment:

gcc -std=gnu99  -c -mtune=generic   -DUSE_CRT_DLL=1 -I 
/x/emacs_files/trunk/git/nt/inc -Demacs  -I. -I. -I../lib -I../lib 
-mtune=generic                 -MMD -MF deps/dispnew.d -MP     -O2 
dispnew.c
In file included from dispnew.c:26:0:
dispnew.c: In function 'init_display':
lisp.h:4611:6: error: 'USE_STACK_LISP_OBJECTS' undeclared (first use in 
this function)
     ((USE_STACK_LISP_OBJECTS      \
       ^

Best Regards
cg





^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Trunk r117932 build failure on mingw64
  2014-09-24 13:34   ` cg
@ 2014-09-24 14:41     ` Eli Zaretskii
  2014-09-24 14:51       ` Andy Moreton
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2014-09-24 14:41 UTC (permalink / raw)
  To: chengang31; +Cc: emacs-devel

> From: cg <chengang31@gmail.com>
> Date: Wed, 24 Sep 2014 21:34:27 +0800
> 
> On 9/24/2014 6:10 PM, Eli Zaretskii wrote:
> >
> > Fixed in trunk revision 117933.
> >
> 
> 
> Looks like it is still broken at the moment:

Because of another commit done since I wrote my mail.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Trunk r117932 build failure on mingw64
  2014-09-24 14:41     ` Eli Zaretskii
@ 2014-09-24 14:51       ` Andy Moreton
  0 siblings, 0 replies; 6+ messages in thread
From: Andy Moreton @ 2014-09-24 14:51 UTC (permalink / raw)
  To: emacs-devel

On Wed 24 Sep 2014, Eli Zaretskii wrote:

>> From: cg <chengang31@gmail.com>
>> Date: Wed, 24 Sep 2014 21:34:27 +0800
>> 
>> On 9/24/2014 6:10 PM, Eli Zaretskii wrote:
>> >
>> > Fixed in trunk revision 117933.
>> >
>> 
>> 
>> Looks like it is still broken at the moment:
>
> Because of another commit done since I wrote my mail.

Trunk r117936 is now building again on mingw64 64bit.

Thanks to all concerned,

    AndyM




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-09-24 14:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-24  9:28 Trunk r117932 build failure on mingw64 Andy Moreton
2014-09-24 10:10 ` Eli Zaretskii
2014-09-24 10:16   ` Eli Zaretskii
2014-09-24 13:34   ` cg
2014-09-24 14:41     ` Eli Zaretskii
2014-09-24 14:51       ` Andy Moreton

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).