unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: bruce.connor.am@gmail.com, deng@randomsample.de, emacs-devel@gnu.org
Subject: Re: When do we merge the commits from emacs-25 onto master?
Date: Tue, 24 Nov 2015 22:14:45 +0200	[thread overview]
Message-ID: <83h9kbxih6.fsf@gnu.org> (raw)
In-Reply-To: <5654BE83.7010608@cs.ucla.edu>

> Cc: bruce.connor.am@gmail.com, emacs-devel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Tue, 24 Nov 2015 11:46:11 -0800
> 
> > Would it work to somehow teach gitmerge.el to use the (fixed) text
> > from ChangeLog.2 as the merge-commit log message, instead of the
> > original log message at emacs-25 commit time?
> 
> A clever idea, and something like that might work, but it sounds 
> brittle. Often, changes to ChangeLog.2 aren't isolated to single 
> commits, and offhand I don't see how in general to figure out which 
> parts of ChangeLog.2 should be matched to which commits.

We shouldn't pay attention to _commits_ that change ChangeLog.2, we
should instead match Git log messages against entries in the
ChangeLog.2 the file in the working tree.

> How about the following idea instead.  Let's put the emacs-25 branch in 
> charge of ChangeLog.2, and put the master branch in charge of a new file 
> ChangeLog.3 that exists only in the master branch. We can do this by 
> updating CHANGELOG_HISTORY_INDEX_MAX to 3 only in the master.  Then 
> merges from emacs-25 to master should be trivial, as people who want to 
> manually edit ChangeLog.2 or to update it via 'make change-history' 
> should do so only in the emacs-25 branch. We'll need to modify 'make 
> ChangeLog' so that in the master it ignores commit messages merged from 
> the emacs-25 branch (I assume this is doable but I haven't checked 
> this). Backporting changes will still be a hassle (we'll need to run 
> 'make change-history' in the master, and then manually update 
> ChangeLog.3 to remove references to the changes being backported to 
> emacs-25), but that's OK.

You mean, "make change-history" on master will update ChangeLog.3 and
the same command on the branch will update ChangeLog.2?  But then how
to prevent the commit log messages from commits merged onto master
from appearing in ChangeLog.3?



  reply	other threads:[~2015-11-24 20:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23 20:36 When do we merge the commits from emacs-25 onto master? Artur Malabarba
2015-11-23 20:51 ` Eli Zaretskii
2015-11-23 22:05 ` Paul Eggert
2015-11-23 22:34   ` Artur Malabarba
2015-11-23 22:43     ` David Engster
2015-11-24 14:25       ` ChangeLog and the release branch (was: When do we merge the commits from emacs-25 onto master?) Artur Malabarba
2015-11-24 13:29         ` ChangeLog and the release branch Dmitry Gutov
2015-11-24 16:24         ` ChangeLog and the release branch (was: When do we merge the commits from emacs-25 onto master?) Eli Zaretskii
2015-11-26 21:07           ` ChangeLog and the release branch Yagnesh Raghava Yakkala
2015-11-27  7:26             ` Eli Zaretskii
2015-11-28 11:50               ` David Engster
2015-11-28 12:14                 ` Eli Zaretskii
2015-11-28 12:36                   ` David Engster
2015-11-28 19:15                     ` John Wiegley
2015-11-24 18:32       ` When do we merge the commits from emacs-25 onto master? Eli Zaretskii
2015-11-24 19:33         ` David Engster
2015-11-24 19:46         ` Paul Eggert
2015-11-24 20:14           ` Eli Zaretskii [this message]
2015-11-24 22:04             ` Paul Eggert
2015-11-25  0:35               ` David Engster
2015-11-25  6:32                 ` Paul Eggert
2015-11-25 18:18                   ` Eli Zaretskii
2015-11-25 18:16                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h9kbxih6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=bruce.connor.am@gmail.com \
    --cc=deng@randomsample.de \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).