* emacs-25 build broken? @ 2015-12-23 13:51 Angelo Graziosi 2015-12-23 15:22 ` Kaushal Modi 2015-12-23 16:28 ` Eli Zaretskii 0 siblings, 2 replies; 16+ messages in thread From: Angelo Graziosi @ 2015-12-23 13:51 UTC (permalink / raw) To: emacs-devel Trying to build emacs-25 on MSYS2/MINGW64 (last commit 09053075225fec8a6cf7a72017a6dfc1ec6b6f0c), the build breaks at this: [...] make[2]: ingresso nella directory "/tmp/mingw-w64-emacs-25-git/src/build-x86_64-w64-mingw32/lisp" ELC /C/msys64/tmp/mingw-w64-emacs-25-git/src/emacs-emacs-25/lisp/language/ethiopic.elc In toplevel form: ../../emacs-emacs-25/lisp/international/ucs-normalize.el:413:11:Error: Wrong type argument: number-or-marker-p, nil Makefile:252: set di istruzioni per l'obiettivo "/C/msys64/tmp/mingw-w64-emacs-25-git/src/emacs-emacs-25/lisp/international/ucs-normalize.elc" non riuscito make[2]: *** [/C/msys64/tmp/mingw-w64-emacs-25-git/src/emacs-emacs-25/lisp/international/ucs-normalize.elc] Errore 1 make[2]: uscita dalla directory "/tmp/mingw-w64-emacs-25-git/src/build-x86_64-w64-mingw32/lisp" Makefile:699: set di istruzioni per l'obiettivo "/C/msys64/tmp/mingw-w64-emacs-25-git/src/emacs-emacs-25/lisp/international/ucs-normalize.elc" non riuscito make[1]: *** [/C/msys64/tmp/mingw-w64-emacs-25-git/src/emacs-emacs-25/lisp/international/ucs-normalize.elc] Errore 2 make[1]: *** Attesa per i processi non terminati.... make[2]: uscita dalla directory "/tmp/mingw-w64-emacs-25-git/src/build-x86_64-w64-mingw32/lisp" make[2]: uscita dalla directory "/tmp/mingw-w64-emacs-25-git/src/build-x86_64-w64-mingw32/lisp" make[1]: uscita dalla directory "/tmp/mingw-w64-emacs-25-git/src/build-x86_64-w64-mingw32/src" Makefile:394: set di istruzioni per l'obiettivo "src" non riuscito make: *** [src] Errore 2 Usually I build master without problems, so could happen I forgot something for emacs-25 branch... TIA, Angelo. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-23 13:51 emacs-25 build broken? Angelo Graziosi @ 2015-12-23 15:22 ` Kaushal Modi 2015-12-23 16:31 ` Eli Zaretskii 2015-12-23 16:28 ` Eli Zaretskii 1 sibling, 1 reply; 16+ messages in thread From: Kaushal Modi @ 2015-12-23 15:22 UTC (permalink / raw) To: Angelo Graziosi, andlind; +Cc: Emacs developers [-- Attachment #1: Type: text/plain, Size: 1845 bytes --] Copying Anders. -- Kaushal Modi On Wed, Dec 23, 2015 at 8:51 AM, Angelo Graziosi <angelo.graziosi@alice.it> wrote: > Trying to build emacs-25 on MSYS2/MINGW64 (last commit > 09053075225fec8a6cf7a72017a6dfc1ec6b6f0c), the build breaks at this: > > [...] > make[2]: ingresso nella directory > "/tmp/mingw-w64-emacs-25-git/src/build-x86_64-w64-mingw32/lisp" > ELC > /C/msys64/tmp/mingw-w64-emacs-25-git/src/emacs-emacs-25/lisp/language/ethiopic.elc > > In toplevel form: > ../../emacs-emacs-25/lisp/international/ucs-normalize.el:413:11:Error: > Wrong type argument: number-or-marker-p, nil > Makefile:252: set di istruzioni per l'obiettivo > "/C/msys64/tmp/mingw-w64-emacs-25-git/src/emacs-emacs-25/lisp/international/ucs-normalize.elc" > non riuscito > make[2]: *** > [/C/msys64/tmp/mingw-w64-emacs-25-git/src/emacs-emacs-25/lisp/international/ucs-normalize.elc] > Errore 1 > make[2]: uscita dalla directory > "/tmp/mingw-w64-emacs-25-git/src/build-x86_64-w64-mingw32/lisp" > Makefile:699: set di istruzioni per l'obiettivo > "/C/msys64/tmp/mingw-w64-emacs-25-git/src/emacs-emacs-25/lisp/international/ucs-normalize.elc" > non riuscito > make[1]: *** > [/C/msys64/tmp/mingw-w64-emacs-25-git/src/emacs-emacs-25/lisp/international/ucs-normalize.elc] > Errore 2 > make[1]: *** Attesa per i processi non terminati.... > make[2]: uscita dalla directory > "/tmp/mingw-w64-emacs-25-git/src/build-x86_64-w64-mingw32/lisp" > make[2]: uscita dalla directory > "/tmp/mingw-w64-emacs-25-git/src/build-x86_64-w64-mingw32/lisp" > make[1]: uscita dalla directory > "/tmp/mingw-w64-emacs-25-git/src/build-x86_64-w64-mingw32/src" > Makefile:394: set di istruzioni per l'obiettivo "src" non riuscito > make: *** [src] Errore 2 > > > Usually I build master without problems, so could happen I forgot > something for emacs-25 branch... > > TIA, > Angelo. > > [-- Attachment #2: Type: text/html, Size: 2375 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-23 15:22 ` Kaushal Modi @ 2015-12-23 16:31 ` Eli Zaretskii 0 siblings, 0 replies; 16+ messages in thread From: Eli Zaretskii @ 2015-12-23 16:31 UTC (permalink / raw) To: Kaushal Modi; +Cc: emacs-devel, andlind, angelo.graziosi > From: Kaushal Modi <kaushal.modi@gmail.com> > Date: Wed, 23 Dec 2015 10:22:01 -0500 > Cc: Emacs developers <emacs-devel@gnu.org> > > Copying Anders. Why him? I don't see any changes he made in ucs-normalize.el. Do you? Does reverting 0905307 solves the problem? ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-23 13:51 emacs-25 build broken? Angelo Graziosi 2015-12-23 15:22 ` Kaushal Modi @ 2015-12-23 16:28 ` Eli Zaretskii 2015-12-23 17:13 ` Angelo Graziosi 1 sibling, 1 reply; 16+ messages in thread From: Eli Zaretskii @ 2015-12-23 16:28 UTC (permalink / raw) To: Angelo Graziosi; +Cc: emacs-devel > From: Angelo Graziosi <angelo.graziosi@alice.it> > Date: Wed, 23 Dec 2015 14:51:58 +0100 > > Trying to build emacs-25 on MSYS2/MINGW64 (last commit > 09053075225fec8a6cf7a72017a6dfc1ec6b6f0c), the build breaks at this: > > [...] > make[2]: ingresso nella directory > "/tmp/mingw-w64-emacs-25-git/src/build-x86_64-w64-mingw32/lisp" > ELC > /C/msys64/tmp/mingw-w64-emacs-25-git/src/emacs-emacs-25/lisp/language/ethiopic.elc > > In toplevel form: > ../../emacs-emacs-25/lisp/international/ucs-normalize.el:413:11:Error: > Wrong type argument: number-or-marker-p, nil It doesn't happen for me, and I see no changes in ucs-normalize.el recently. Moreover, if I touch ucs-normalize.el, it then compiles cleanly. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-23 16:28 ` Eli Zaretskii @ 2015-12-23 17:13 ` Angelo Graziosi 2015-12-23 17:17 ` Kaushal Modi 0 siblings, 1 reply; 16+ messages in thread From: Angelo Graziosi @ 2015-12-23 17:13 UTC (permalink / raw) To: emacs-devel Il 23/12/2015 17:28, Eli Zaretskii ha scritto: >> From: Angelo Graziosi <angelo.graziosi@alice.it> >> Date: Wed, 23 Dec 2015 14:51:58 +0100 >> >> Trying to build emacs-25 on MSYS2/MINGW64 (last commit >> 09053075225fec8a6cf7a72017a6dfc1ec6b6f0c), the build breaks at this: >> >> [...] >> make[2]: ingresso nella directory >> "/tmp/mingw-w64-emacs-25-git/src/build-x86_64-w64-mingw32/lisp" >> ELC >> /C/msys64/tmp/mingw-w64-emacs-25-git/src/emacs-emacs-25/lisp/language/ethiopic.elc >> >> In toplevel form: >> ../../emacs-emacs-25/lisp/international/ucs-normalize.el:413:11:Error: >> Wrong type argument: number-or-marker-p, nil > > [...] and I see no changes in ucs-normalize.el I noticed this too.. I built yesterday master (r122206.075f8d9) without problems and so tried today with emacs-25 branch using the same method and found that issue. Maybe it is a "false" alarm. I will retry to see if comes out another time.. > recently. Moreover, if I touch ucs-normalize.el, it then compiles > cleanly. > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-23 17:13 ` Angelo Graziosi @ 2015-12-23 17:17 ` Kaushal Modi 2015-12-23 18:27 ` Anders Lindgren 0 siblings, 1 reply; 16+ messages in thread From: Kaushal Modi @ 2015-12-23 17:17 UTC (permalink / raw) To: Angelo Graziosi, andlind; +Cc: Emacs developers [-- Attachment #1: Type: text/plain, Size: 455 bytes --] > Why him? I don't see any changes he made in ucs-normalize.el. Do you? Sorry, I saw that that commit by Anders added the (require 'ucs-normalize) and thought that this error was related to that. I just rebuilt using that commit and the build finished fine. > Does reverting 0905307 solves the problem? Actually I just finished building using make bootstrap from the lastest commit on emacs-25 and it finished fine. Please ignore this ping, Anders. [-- Attachment #2: Type: text/html, Size: 837 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-23 17:17 ` Kaushal Modi @ 2015-12-23 18:27 ` Anders Lindgren 2015-12-23 22:47 ` Angelo Graziosi 2015-12-24 0:07 ` Angelo Graziosi 0 siblings, 2 replies; 16+ messages in thread From: Anders Lindgren @ 2015-12-23 18:27 UTC (permalink / raw) To: Kaushal Modi; +Cc: Emacs developers, Angelo Graziosi [-- Attachment #1: Type: text/plain, Size: 760 bytes --] Hi! I'm glad that you managed to get the build up and running. Sending me a CC was fine, as I just pushed a change related to ucs-normalize, even though it (luckily) wasn't the culprit. -- Anders On Wed, Dec 23, 2015 at 6:17 PM, Kaushal Modi <kaushal.modi@gmail.com> wrote: > > Why him? I don't see any changes he made in ucs-normalize.el. Do you? > > Sorry, I saw that that commit by Anders added the (require 'ucs-normalize) > and thought that this error was related to that. I just rebuilt using that > commit and the build finished fine. > > > Does reverting 0905307 solves the problem? > > Actually I just finished building using make bootstrap from the lastest > commit on emacs-25 and it finished fine. > > Please ignore this ping, Anders. > [-- Attachment #2: Type: text/html, Size: 1544 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-23 18:27 ` Anders Lindgren @ 2015-12-23 22:47 ` Angelo Graziosi 2015-12-23 23:44 ` Herbert J. Skuhra 2015-12-24 0:07 ` Angelo Graziosi 1 sibling, 1 reply; 16+ messages in thread From: Angelo Graziosi @ 2015-12-23 22:47 UTC (permalink / raw) To: Emacs developers [-- Attachment #1: Type: text/plain, Size: 1413 bytes --] Il 23/12/2015 19:27, Anders Lindgren ha scritto: > Hi! > > I'm glad that you managed to get the build up and running. > > Sending me a CC was fine, as I just pushed a change related to > ucs-normalize, even though it (luckily) wasn't the culprit. > Indeed... I have tried (on MSYS2/MINGW64) both with the tarball http://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-68218d82649c7336874438a7010a180ad3e50803.tar.gz and with the git repo, git clone --branch=emacs-25 git://git.savannah.gnu.org/emacs.git emacs-25 but the build of emacs-25 branch always fails in the same manner, [...] make[2]: ingresso nella directory "/tmp/emacs-25/lisp" ELC ../lisp/international/ucs-normalize.elc In toplevel form: international/ucs-normalize.el:413:11:Error: Wrong type argument: number-or-marker-p, nil Makefile:252: set di istruzioni per l'obiettivo "../lisp/international/ucs-normalize.elc" non riuscito [...] Instead, when I build master (1dcf9a5d2a727913bc53c68756bdaf6db5573671, for example) it builds and works... For the sake of testing the builds, I did this: $ ./autogen.sh $ ./configure --build=x86_64-w64-mingw32 --without-imagemagick 2>&1 | tee -a emacs-build.log $ make (Usually, I build Emacs with following the MSYS2 method, https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-emacs-git) For completeness, I have attached the compressed build log. Angelo [-- Attachment #2: emacs-25-build.log.bz2 --] [-- Type: application/octet-stream, Size: 8471 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-23 22:47 ` Angelo Graziosi @ 2015-12-23 23:44 ` Herbert J. Skuhra 0 siblings, 0 replies; 16+ messages in thread From: Herbert J. Skuhra @ 2015-12-23 23:44 UTC (permalink / raw) To: emacs-devel On Wed, 23 Dec 2015 23:47:10 +0100, Angelo Graziosi <angelo.graziosi@alice.it> wrote: > > but the build of emacs-25 branch always fails in the same manner, > > [...] > make[2]: ingresso nella directory "/tmp/emacs-25/lisp" > ELC ../lisp/international/ucs-normalize.elc > > In toplevel form: > international/ucs-normalize.el:413:11:Error: Wrong type argument: > number-or-marker-p, nil > Makefile:252: set di istruzioni per l'obiettivo > "../lisp/international/ucs-normalize.elc" non riuscito > [...] I have the same issue on FreeBSD 10.2-STABLE and MacOS X 10.11.3. The breakage starts with commit 09053075225fec8a6cf7a72017a6dfc1ec6b6f0c. -- Herbert ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-23 18:27 ` Anders Lindgren 2015-12-23 22:47 ` Angelo Graziosi @ 2015-12-24 0:07 ` Angelo Graziosi 2015-12-24 2:00 ` Paul Eggert 1 sibling, 1 reply; 16+ messages in thread From: Angelo Graziosi @ 2015-12-24 0:07 UTC (permalink / raw) To: Anders Lindgren, Kaushal Modi; +Cc: Emacs developers Ok. I tried the build also on GNU/Linux (Mint 17.3), a GTK build with clang, and current 25 branch fails to build in the same manner I described in this thread. So the issue is not MSYS2/MINGW64 specific. So I tried a sort of "binary" search to find when the build was broken.. I tried with this source: http://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-781770b4dcfe44b255e94e16479fd14633803640.tar.gz from this commit: Tom Tromey: Fix bug #18588 by making bug-reference-bug-regexp more lenient and it builds fine! Thentried the next commit: http://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-09053075225fec8a6cf7a72017a6dfc1ec6b6f0c.tar.gz Anders Lindgren: File-name completion of non-ASCII characters on OS X (bug#22169) and it failed as described... Definitively Emacs-25 branch is broken, at leas on MSYS2/MinGW64 and GNU/Linux Mint 17.3 But.. have you tried to build in a virgin source tree? For example with a tarball from http://git.savannah.gnu.org/cgit/emacs.git/snapshot or in a just git cloned repo: git clone -b emacs-25 git://git.sv.gnu.org/emacs.git ? Angelo Il 23/12/2015 19:27, Anders Lindgren ha scritto: > Hi! > > I'm glad that you managed to get the build up and running. > > Sending me a CC was fine, as I just pushed a change related to > ucs-normalize, even though it (luckily) wasn't the culprit. > > -- Anders > > On Wed, Dec 23, 2015 at 6:17 PM, Kaushal Modi <kaushal.modi@gmail.com> > wrote: > >>> Why him? I don't see any changes he made in ucs-normalize.el. Do you? >> >> Sorry, I saw that that commit by Anders added the (require 'ucs-normalize) >> and thought that this error was related to that. I just rebuilt using that >> commit and the build finished fine. >> >>> Does reverting 0905307 solves the problem? >> >> Actually I just finished building using make bootstrap from the lastest >> commit on emacs-25 and it finished fine. >> >> Please ignore this ping, Anders. >> > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-24 0:07 ` Angelo Graziosi @ 2015-12-24 2:00 ` Paul Eggert 2015-12-24 8:45 ` Anders Lindgren 0 siblings, 1 reply; 16+ messages in thread From: Paul Eggert @ 2015-12-24 2:00 UTC (permalink / raw) To: Angelo Graziosi, Anders Lindgren, Kaushal Modi; +Cc: Emacs developers Angelo Graziosi wrote: > http://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-09053075225fec8a6cf7a72017a6dfc1ec6b6f0c.tar.gz > > Anders Lindgren: File-name completion of non-ASCII characters on OS X (bug#22169) > > and it failed as described... > > > Definitively Emacs-25 branch is broken, at leas on MSYS2/MinGW64 and GNU/Linux > Mint 17.3 It is also broken on Ubuntu 15.10, with the same symptoms: ELC ../lisp/international/ucs-normalize.elc In toplevel form: international/ucs-normalize.el:413:11:Error: Wrong type argument: number-or-marker-p, nil I confirmed that a fresh checkout of the previous commit 781770b4dcfe44b255e94e16479fd14633803640 lacks the problem, and that a fresh checkout of 09053075225fec8a6cf7a72017a6dfc1ec6b6f0c does have the problem. Fresh checkouts after that all seem to have the problem, too (I checked up through 9576e885ef33d08b53d8296e262e09d9deda9523). I built from a fresh checkout by running "./autogen.sh && ./configure --enable-gcc-warnings && make -j5". ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-24 2:00 ` Paul Eggert @ 2015-12-24 8:45 ` Anders Lindgren 2015-12-24 9:06 ` Anders Lindgren 0 siblings, 1 reply; 16+ messages in thread From: Anders Lindgren @ 2015-12-24 8:45 UTC (permalink / raw) To: Paul Eggert; +Cc: Kaushal Modi, Emacs developers, Angelo Graziosi [-- Attachment #1: Type: text/plain, Size: 1258 bytes --] I see the same problem here, when building from scratch. I'll revert the commit, as soon as I can. -- Anders On Thu, Dec 24, 2015 at 3:00 AM, Paul Eggert <eggert@cs.ucla.edu> wrote: > Angelo Graziosi wrote: > > >> http://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-09053075225fec8a6cf7a72017a6dfc1ec6b6f0c.tar.gz >> >> Anders Lindgren: File-name completion of non-ASCII characters on OS X >> (bug#22169) >> >> and it failed as described... >> >> >> Definitively Emacs-25 branch is broken, at leas on MSYS2/MinGW64 and >> GNU/Linux >> Mint 17.3 >> > > It is also broken on Ubuntu 15.10, with the same symptoms: > > ELC ../lisp/international/ucs-normalize.elc > > In toplevel form: international/ucs-normalize.el:413:11:Error: Wrong type > argument: number-or-marker-p, nil > > > I confirmed that a fresh checkout of the previous commit > 781770b4dcfe44b255e94e16479fd14633803640 lacks the problem, and that a > fresh checkout of 09053075225fec8a6cf7a72017a6dfc1ec6b6f0c does have the > problem. Fresh checkouts after that all seem to have the problem, too (I > checked up through 9576e885ef33d08b53d8296e262e09d9deda9523). > > I built from a fresh checkout by running "./autogen.sh && ./configure > --enable-gcc-warnings && make -j5". > [-- Attachment #2: Type: text/html, Size: 1994 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-24 8:45 ` Anders Lindgren @ 2015-12-24 9:06 ` Anders Lindgren 2015-12-24 17:01 ` Eli Zaretskii 0 siblings, 1 reply; 16+ messages in thread From: Anders Lindgren @ 2015-12-24 9:06 UTC (permalink / raw) To: Paul Eggert; +Cc: Kaushal Modi, Emacs developers, Angelo Graziosi [-- Attachment #1: Type: text/plain, Size: 1462 bytes --] The commit has been reverted. Sorry about the inconvenience. -- Anders On Thu, Dec 24, 2015 at 9:45 AM, Anders Lindgren <andlind@gmail.com> wrote: > I see the same problem here, when building from scratch. > > I'll revert the commit, as soon as I can. > > -- Anders > > On Thu, Dec 24, 2015 at 3:00 AM, Paul Eggert <eggert@cs.ucla.edu> wrote: > >> Angelo Graziosi wrote: >> >> >>> http://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-09053075225fec8a6cf7a72017a6dfc1ec6b6f0c.tar.gz >>> >>> Anders Lindgren: File-name completion of non-ASCII characters on OS X >>> (bug#22169) >>> >>> and it failed as described... >>> >>> >>> Definitively Emacs-25 branch is broken, at leas on MSYS2/MinGW64 and >>> GNU/Linux >>> Mint 17.3 >>> >> >> It is also broken on Ubuntu 15.10, with the same symptoms: >> >> ELC ../lisp/international/ucs-normalize.elc >> >> In toplevel form: international/ucs-normalize.el:413:11:Error: Wrong type >> argument: number-or-marker-p, nil >> >> >> I confirmed that a fresh checkout of the previous commit >> 781770b4dcfe44b255e94e16479fd14633803640 lacks the problem, and that a >> fresh checkout of 09053075225fec8a6cf7a72017a6dfc1ec6b6f0c does have the >> problem. Fresh checkouts after that all seem to have the problem, too (I >> checked up through 9576e885ef33d08b53d8296e262e09d9deda9523). >> >> I built from a fresh checkout by running "./autogen.sh && ./configure >> --enable-gcc-warnings && make -j5". >> > > [-- Attachment #2: Type: text/html, Size: 2555 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-24 9:06 ` Anders Lindgren @ 2015-12-24 17:01 ` Eli Zaretskii 2015-12-24 18:35 ` Anders Lindgren 0 siblings, 1 reply; 16+ messages in thread From: Eli Zaretskii @ 2015-12-24 17:01 UTC (permalink / raw) To: Anders Lindgren; +Cc: eggert, emacs-devel, angelo.graziosi, kaushal.modi > Date: Thu, 24 Dec 2015 10:06:00 +0100 > From: Anders Lindgren <andlind@gmail.com> > Cc: Kaushal Modi <kaushal.modi@gmail.com>, > Emacs developers <emacs-devel@gnu.org>, > Angelo Graziosi <angelo.graziosi@alice.it> > > The commit has been reverted. Sorry about the inconvenience. Thanks, Anders. For the future, there's no need to revert a commit, unless it's clear that there's a bug in the commit itself. In your case, the commit is correct and bug-free, and it fixes a real problem. In such cases, the way to fix any fallout is to find the new problem exposed by the commit and fix that new problem. If people are annoyed by the temporary breakage of the branch, they can always reset their HEAD to a prior commit, until the problem is fixed. They can even try debugging the new problem and fixing it ;-) Anyway, I found the reason for these weird messages. It was a subtle issue with the code in ucs-normalize.el that was always there, and was simply exposed by promoting it to be compiled by bootstrap-emacs earlier in the bootstrap process. So please revert the revert, and I will follow up with the changes that fix the broken bootstrap. Thanks. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-24 17:01 ` Eli Zaretskii @ 2015-12-24 18:35 ` Anders Lindgren 2015-12-24 19:19 ` Eli Zaretskii 0 siblings, 1 reply; 16+ messages in thread From: Anders Lindgren @ 2015-12-24 18:35 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Paul Eggert, emacs-devel, Angelo Graziosi, Kaushal Modi [-- Attachment #1: Type: text/plain, Size: 1967 bytes --] Hi! Normally, I would try to fix problems rather than backing out of a commit. However, today it was not possible for me to give the problem any attention. Given the severity (it broke the build process), I decided to revert it so that I could look at in piece and quiet. When the fix to ucs-normalize has been pushed, I will verify that Emacs builds from scratch with my patch is installed (on multiple systems), before publishing it again. Anyway, I will post further messages on this to the "22169" issue, to avoid filling emacs-devel and personal mail boxes with (possibly) irrelevant information. Finally, thanks to everybody reporting this. -- Anders On Thu, Dec 24, 2015 at 6:01 PM, Eli Zaretskii <eliz@gnu.org> wrote: > > Date: Thu, 24 Dec 2015 10:06:00 +0100 > > From: Anders Lindgren <andlind@gmail.com> > > Cc: Kaushal Modi <kaushal.modi@gmail.com>, > > Emacs developers <emacs-devel@gnu.org>, > > Angelo Graziosi <angelo.graziosi@alice.it> > > > > The commit has been reverted. Sorry about the inconvenience. > > Thanks, Anders. > > For the future, there's no need to revert a commit, unless it's clear > that there's a bug in the commit itself. In your case, the commit is > correct and bug-free, and it fixes a real problem. In such cases, the > way to fix any fallout is to find the new problem exposed by the > commit and fix that new problem. If people are annoyed by the > temporary breakage of the branch, they can always reset their HEAD to > a prior commit, until the problem is fixed. They can even try > debugging the new problem and fixing it ;-) > > Anyway, I found the reason for these weird messages. It was a subtle > issue with the code in ucs-normalize.el that was always there, and was > simply exposed by promoting it to be compiled by bootstrap-emacs > earlier in the bootstrap process. > > So please revert the revert, and I will follow up with the changes > that fix the broken bootstrap. > > Thanks. > [-- Attachment #2: Type: text/html, Size: 2753 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: emacs-25 build broken? 2015-12-24 18:35 ` Anders Lindgren @ 2015-12-24 19:19 ` Eli Zaretskii 0 siblings, 0 replies; 16+ messages in thread From: Eli Zaretskii @ 2015-12-24 19:19 UTC (permalink / raw) To: Anders Lindgren; +Cc: eggert, emacs-devel, angelo.graziosi, kaushal.modi > Date: Thu, 24 Dec 2015 19:35:48 +0100 > From: Anders Lindgren <andlind@gmail.com> > Cc: Paul Eggert <eggert@cs.ucla.edu>, Kaushal Modi <kaushal.modi@gmail.com>, > emacs-devel <emacs-devel@gnu.org>, Angelo Graziosi <angelo.graziosi@alice.it> > > Normally, I would try to fix problems rather than backing out of a commit. > However, today it was not possible for me to give the problem any attention. > Given the severity (it broke the build process), I decided to revert it so that > I could look at in piece and quiet. I'm saying that it's not a disaster that a bug like that stays unfixed for a day or two. (It wasn't meant to be a criticism on your behalf.) > When the fix to ucs-normalize has been pushed, I will verify that Emacs builds > from scratch with my patch is installed (on multiple systems), before > publishing it again. Not sure what you are saying. If you mean you want to wait for me to push my changes, then part of them need your patch, because they modify some of the code you added. I can send you my changes, so you could try them before both parts are installed, if you want. ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2015-12-24 19:19 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-12-23 13:51 emacs-25 build broken? Angelo Graziosi 2015-12-23 15:22 ` Kaushal Modi 2015-12-23 16:31 ` Eli Zaretskii 2015-12-23 16:28 ` Eli Zaretskii 2015-12-23 17:13 ` Angelo Graziosi 2015-12-23 17:17 ` Kaushal Modi 2015-12-23 18:27 ` Anders Lindgren 2015-12-23 22:47 ` Angelo Graziosi 2015-12-23 23:44 ` Herbert J. Skuhra 2015-12-24 0:07 ` Angelo Graziosi 2015-12-24 2:00 ` Paul Eggert 2015-12-24 8:45 ` Anders Lindgren 2015-12-24 9:06 ` Anders Lindgren 2015-12-24 17:01 ` Eli Zaretskii 2015-12-24 18:35 ` Anders Lindgren 2015-12-24 19:19 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).