From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Don't complain about changed file when it hasn't changed
Date: Fri, 02 Sep 2016 18:26:08 +0300
Message-ID: <83h99ye31r.fsf@gnu.org>
References: <jwvy43g2ze5.fsf-monnier+emacs@gnu.org> <83oa4bbq5b.fsf@gnu.org>
	<jwv8tvfbpq6.fsf-monnier+gmane.emacs.devel@gnu.org>
	<83a8funuqw.fsf@gnu.org>
	<jwv4m62xnti.fsf-monnier+gmane.emacs.devel@gnu.org>
	<83twe2mdpu.fsf@gnu.org> <jwv60qiw56z.fsf-monnier+Inbox@gnu.org>
	<83h9a2mabl.fsf@gnu.org>
	<jwvinuiuoax.fsf-monnier+gmane.emacs.devel@gnu.org>
	<83k2evg26c.fsf@gnu.org> <jwvy43ajpk5.fsf-monnier+emacs@gnu.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1472830016 31373 195.159.176.226 (2 Sep 2016 15:26:56 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Fri, 2 Sep 2016 15:26:56 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 02 17:26:52 2016
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1bfqMe-00078M-JH
	for ged-emacs-devel@m.gmane.org; Fri, 02 Sep 2016 17:26:44 +0200
Original-Received: from localhost ([::1]:42692 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1bfqMc-0007iU-Du
	for ged-emacs-devel@m.gmane.org; Fri, 02 Sep 2016 11:26:42 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41108)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1bfqMV-0007iO-P6
	for emacs-devel@gnu.org; Fri, 02 Sep 2016 11:26:36 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1bfqMS-00049F-Ia
	for emacs-devel@gnu.org; Fri, 02 Sep 2016 11:26:35 -0400
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55057)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1bfqMS-000487-Fu; Fri, 02 Sep 2016 11:26:32 -0400
Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3450
	helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1bfqMO-00036K-La; Fri, 02 Sep 2016 11:26:31 -0400
In-reply-to: <jwvy43ajpk5.fsf-monnier+emacs@gnu.org> (message from Stefan
	Monnier on Fri, 02 Sep 2016 11:22:15 -0400)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:207135
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/207135>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Fri, 02 Sep 2016 11:22:15 -0400
> 
> > My preference would be to have the test in the caller, because I doubt
> > that anyone who replaces that function would want to lose the test.
> > But that preference is not very strong.
> 
> How 'bout the patch below, then,

Looks good to me, thank you very much.