From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 ea1960b: Avoid resetting track-mouse by mouse clicks Date: Wed, 21 Sep 2016 19:02:30 +0300 Message-ID: <83h999fdgp.fsf@gnu.org> References: <20160921150102.25705.25564@vcs.savannah.gnu.org> <20160921150102.AA77722016F@vcs.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1474474474 18143 195.159.176.226 (21 Sep 2016 16:14:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Sep 2016 16:14:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 21 18:14:30 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmkA1-0002No-Cf for ged-emacs-devel@m.gmane.org; Wed, 21 Sep 2016 18:14:13 +0200 Original-Received: from localhost ([::1]:43633 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmk9z-0007Vu-Ki for ged-emacs-devel@m.gmane.org; Wed, 21 Sep 2016 12:14:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmjyQ-0005Xf-4p for emacs-devel@gnu.org; Wed, 21 Sep 2016 12:02:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmjyK-0000hs-JW for emacs-devel@gnu.org; Wed, 21 Sep 2016 12:02:13 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmjyK-0000hb-H8; Wed, 21 Sep 2016 12:02:08 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3788 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bmjyI-0001MW-R3; Wed, 21 Sep 2016 12:02:07 -0400 In-reply-to: (message from Stefan Monnier on Wed, 21 Sep 2016 11:10:34 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207663 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii > Date: Wed, 21 Sep 2016 11:10:34 -0400 > > > + (old-track-mouse track-mouse)) > [...] > > + t (lambda () (setq track-mouse old-track-mouse))))))) > > To allow two packages to set track-mouse without one setting being > (temporally) nested within the other, we could do > > (push 'mouse-drag track-mouse) > [...] > (setq track-mouse (delq 'mouse-drag track-mouse)) But that wasn't the purpose of the fix. What you suggest fixes a different problem, one that has yet to be reported; the original code which simply gave track-mouse the nil value had the same problem. Right?