* Re: [Emacs-diffs] emacs-25 197a6bc: Fix horizontal scrolling during Isearch
[not found] ` <20161008093643.BC95522015F@vcs.savannah.gnu.org>
@ 2016-10-08 14:26 ` Stefan Monnier
2016-10-08 14:45 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2016-10-08 14:26 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
> * lisp/isearch.el (isearch-update): Compute the window's body
> width in a way that is correct when there are no fringes.
> (Bug#24584)
[...]
> - (>= (car visible-p) (window-body-width nil t)))
> + (>= (car visible-p)
> + (* (window-max-chars-per-line) (frame-char-width))))
Hmm... shouldn't window-body-width return the right answer even when
there are no fringes?
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] emacs-25 197a6bc: Fix horizontal scrolling during Isearch
2016-10-08 14:26 ` [Emacs-diffs] emacs-25 197a6bc: Fix horizontal scrolling during Isearch Stefan Monnier
@ 2016-10-08 14:45 ` Eli Zaretskii
2016-10-08 15:43 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2016-10-08 14:45 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Sat, 08 Oct 2016 10:26:21 -0400
>
> > * lisp/isearch.el (isearch-update): Compute the window's body
> > width in a way that is correct when there are no fringes.
> > (Bug#24584)
> [...]
> > - (>= (car visible-p) (window-body-width nil t)))
> > + (>= (car visible-p)
> > + (* (window-max-chars-per-line) (frame-char-width))))
>
> Hmm... shouldn't window-body-width return the right answer even when
> there are no fringes?
We were too afraid to make that change at the time, because some
callers don't (or might not) want that.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] emacs-25 197a6bc: Fix horizontal scrolling during Isearch
2016-10-08 14:45 ` Eli Zaretskii
@ 2016-10-08 15:43 ` Stefan Monnier
2016-10-08 15:57 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2016-10-08 15:43 UTC (permalink / raw)
To: emacs-devel
>> > * lisp/isearch.el (isearch-update): Compute the window's body
>> > width in a way that is correct when there are no fringes.
>> > (Bug#24584)
>> [...]
>> > - (>= (car visible-p) (window-body-width nil t)))
>> > + (>= (car visible-p)
>> > + (* (window-max-chars-per-line) (frame-char-width))))
>>
>> Hmm... shouldn't window-body-width return the right answer even when
>> there are no fringes?
> We were too afraid to make that change at the time, because some
> callers don't (or might not) want that.
Ah, so this is only for the emacs-25 branch, and on master we'll have
"the right fix" instead? Makes sense, sorry 'bout the noise,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] emacs-25 197a6bc: Fix horizontal scrolling during Isearch
2016-10-08 15:43 ` Stefan Monnier
@ 2016-10-08 15:57 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2016-10-08 15:57 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sat, 08 Oct 2016 11:43:11 -0400
>
> >> > * lisp/isearch.el (isearch-update): Compute the window's body
> >> > width in a way that is correct when there are no fringes.
> >> > (Bug#24584)
> >> [...]
> >> > - (>= (car visible-p) (window-body-width nil t)))
> >> > + (>= (car visible-p)
> >> > + (* (window-max-chars-per-line) (frame-char-width))))
> >>
> >> Hmm... shouldn't window-body-width return the right answer even when
> >> there are no fringes?
> > We were too afraid to make that change at the time, because some
> > callers don't (or might not) want that.
>
> Ah, so this is only for the emacs-25 branch, and on master we'll have
> "the right fix" instead?
Not necessarily, see
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22891#59
Volunteers are welcome to review the users of window-body-width and
suggest which ones to convert.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-08 15:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20161008093643.10907.90387@vcs.savannah.gnu.org>
[not found] ` <20161008093643.BC95522015F@vcs.savannah.gnu.org>
2016-10-08 14:26 ` [Emacs-diffs] emacs-25 197a6bc: Fix horizontal scrolling during Isearch Stefan Monnier
2016-10-08 14:45 ` Eli Zaretskii
2016-10-08 15:43 ` Stefan Monnier
2016-10-08 15:57 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).