From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: libnettle/libhogweed WIP Date: Sun, 16 Apr 2017 09:51:23 +0300 Message-ID: <83h91og80k.fsf@gnu.org> References: <83a89gq3us.fsf@gnu.org> <87bmtjiv0w.fsf_-_@lifelogs.com> <83o9xjn06c.fsf@gnu.org> <87shmeb5ln.fsf_-_@lifelogs.com> <83y3w5z1ez.fsf@gnu.org> <87lgr6yakj.fsf@lifelogs.com> <87wpamww9k.fsf@lifelogs.com> <8337daggnj.fsf@gnu.org> <87d1cdwxt6.fsf@lifelogs.com> <83tw5pg1q3.fsf@gnu.org> <87zifhulc2.fsf@lifelogs.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1492325462 25840 195.159.176.226 (16 Apr 2017 06:51:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Apr 2017 06:51:02 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 16 08:50:58 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cze1R-0006cL-NL for ged-emacs-devel@m.gmane.org; Sun, 16 Apr 2017 08:50:57 +0200 Original-Received: from localhost ([::1]:59443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cze1X-0005Pj-KP for ged-emacs-devel@m.gmane.org; Sun, 16 Apr 2017 02:51:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cze1R-0005PR-BB for emacs-devel@gnu.org; Sun, 16 Apr 2017 02:50:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cze1O-0001ex-9n for emacs-devel@gnu.org; Sun, 16 Apr 2017 02:50:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cze1O-0001et-6F for emacs-devel@gnu.org; Sun, 16 Apr 2017 02:50:54 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3470 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cze1N-0006fK-Gc for emacs-devel@gnu.org; Sun, 16 Apr 2017 02:50:53 -0400 In-reply-to: <87zifhulc2.fsf@lifelogs.com> (message from Ted Zlatanov on Sat, 15 Apr 2017 22:39:57 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213991 Archived-At: > From: Ted Zlatanov > Date: Sat, 15 Apr 2017 22:39:57 -0400 > > When I replace gnutls.c:1828 > > return make_unibyte_string (SSDATA (storage), storage_length); > > with > > STRING_SET_CHARS (storage, storage_length); > return storage; > > I get a segfault running the tests: An alternative is to use SAFE_ALLOCA to allocate a C string while you manipulate it, and then convert it to a unibyte Lisp string with make_unibyte_string, just before the function returns.