From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix use of sockaddr_in Date: Sat, 13 May 2017 19:52:02 +0300 Message-ID: <83h90o8zt9.fsf@gnu.org> References: <83shk989r5.fsf@gnu.org> <20170513150837.31184-1-phst@google.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1494694361 10489 195.159.176.226 (13 May 2017 16:52:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 13 May 2017 16:52:41 +0000 (UTC) Cc: phst@google.com, emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 13 18:52:37 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9aHS-0002Uz-8m for ged-emacs-devel@m.gmane.org; Sat, 13 May 2017 18:52:34 +0200 Original-Received: from localhost ([::1]:58316 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9aHU-00063j-K1 for ged-emacs-devel@m.gmane.org; Sat, 13 May 2017 12:52:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9aHO-00063R-Ec for emacs-devel@gnu.org; Sat, 13 May 2017 12:52:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9aHN-0002Rx-Ru for emacs-devel@gnu.org; Sat, 13 May 2017 12:52:30 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9aHF-0002DP-V0; Sat, 13 May 2017 12:52:21 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1198 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d9aHF-0002cY-49; Sat, 13 May 2017 12:52:21 -0400 In-reply-to: <20170513150837.31184-1-phst@google.com> (message from Philipp Stephani on Sat, 13 May 2017 17:08:37 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214826 Archived-At: > From: Philipp Stephani > Date: Sat, 13 May 2017 17:08:37 +0200 > Cc: Philipp Stephani > > Fixes an access violation detected by AddressSanitizer. > > * process.c (connect_network_socket): Use sockaddr_storage > structure instead of sockaddr_in. Only sockaddr_storage is > guaranteed to be large enough for all address families. Thanks. The first hunk doesn't seem to be necessary, though: in both IPv4 and IPv6 structures, the port is at the same offset and has the same size. So I'd rather put an assertion there, to verify that the offsets and sizes are the same (because the standards don't guarantee that), and that's all.