From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Clean up a couple of compiler warnings Date: Thu, 18 May 2017 23:40:01 +0300 Message-ID: <83h90h5272.fsf@gnu.org> References: <20170518202450.75747-1-phst@google.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1495140092 16184 195.159.176.226 (18 May 2017 20:41:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 May 2017 20:41:32 +0000 (UTC) Cc: phst@google.com, emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 18 22:41:26 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBSEg-00041t-1L for ged-emacs-devel@m.gmane.org; Thu, 18 May 2017 22:41:26 +0200 Original-Received: from localhost ([::1]:55443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBSEl-0005Xc-Gs for ged-emacs-devel@m.gmane.org; Thu, 18 May 2017 16:41:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBSDT-0005Qu-0z for emacs-devel@gnu.org; Thu, 18 May 2017 16:40:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBSDS-00079e-7g for emacs-devel@gnu.org; Thu, 18 May 2017 16:40:11 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBSDQ-00077f-Lq; Thu, 18 May 2017 16:40:08 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2899 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dBSDP-0001m2-SX; Thu, 18 May 2017 16:40:08 -0400 In-reply-to: <20170518202450.75747-1-phst@google.com> (message from Philipp Stephani on Thu, 18 May 2017 22:24:50 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214963 Archived-At: > From: Philipp Stephani > Date: Thu, 18 May 2017 22:24:50 +0200 > Cc: Philipp Stephani > > * emacs.c (using_utf8): Don't assume anything about mbstate_t type. > > * fileio.c (file_name_case_insensitive_p): Add cast. > > * lread.c (string_to_number): Use constants of double type. > * editfns.c (decode_float_time): > * fns.c (make_hash_table, maybe_resize_hash_table) > (Fhash_table_rehash_size, Fhash_table_rehash_threshold): > Explicitly cast floating-point values. > > * sysdep.c (system_process_attributes): Remove unused variables. > > * emacs-module.c (MODULE_SETJMP_1): Mark dummy variable as unused. Could you please show all the warnings which triggered these changes? Some of the changes look very strange to me, so I'd like to see the warnings first. Thanks.