From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers landed on master Date: Sun, 16 Jul 2017 17:10:48 +0300 Message-ID: <83h8yceal3.fsf@gnu.org> References: <83k23jl5ra.fsf@gnu.org> <87r2xqo8p7.fsf@lylat> <83lgnxk7v6.fsf@gnu.org> <87shi5jk2w.fsf@lylat> <83lgnwi3k3.fsf@gnu.org> <87a84crq31.fsf@lylat> <834lujj9d5.fsf@gnu.org> <87pod67lgi.fsf@lylat> <83fue1iur9.fsf@gnu.org> <87d190j0tz.fsf@lylat> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1500214301 29120 195.159.176.226 (16 Jul 2017 14:11:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Jul 2017 14:11:41 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alex Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 16 16:11:37 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWkGb-0006ra-Mr for ged-emacs-devel@m.gmane.org; Sun, 16 Jul 2017 16:11:25 +0200 Original-Received: from localhost ([::1]:45383 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWkGh-0006lm-54 for ged-emacs-devel@m.gmane.org; Sun, 16 Jul 2017 10:11:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWkFx-0006lh-TI for emacs-devel@gnu.org; Sun, 16 Jul 2017 10:10:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWkFu-0000lC-DX for emacs-devel@gnu.org; Sun, 16 Jul 2017 10:10:45 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWkFt-0000kS-Vq; Sun, 16 Jul 2017 10:10:42 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2690 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dWkFt-000823-Do; Sun, 16 Jul 2017 10:10:41 -0400 In-reply-to: <87d190j0tz.fsf@lylat> (message from Alex on Sun, 16 Jul 2017 01:30:16 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216726 Archived-At: > From: Alex > Cc: emacs-devel@gnu.org > Date: Sun, 16 Jul 2017 01:30:16 -0600 > > > cus-load.el is auto-generated. Did the rule which updates it in > > lisp/Makefile get running after your changes, and was cus-load.el > > regenerated as result? If not, maybe you need to run that rule by > > hand. > > I'm still not well-versed in Emacs's build system. cus-load doesn't get > updated automatically for me (I had to manually run the target). Is this > expected? Yes, I think so. > It appears that no rule forces cus-load to be regenerated, and > only bootstrap-clean removes the file. Indeed, I think the idea is that you should go into the lisp directory and run "make custom-deps" there by hand. This only runs automatically at bootstrap time. > After pulling changes, all I do is run "make -j4"; is it recommended to > run extra rules each time, or just when I notice issues? The latter. > >> Would it be better to skip creating a new defgroup and have all > >> variables just be in the display group, or are you in favour of a new > >> group just for line numbers? > > > > If it's a hassle to make a new group, we can stay in the display > > group. > > It's not a hassle, but I was looking at the git-blame for cus-edit and > noticed that most of the entries are quite old. Is this group important > enough to add to the file? Not terribly important, no. > It looks like I could just leave the defgroup definition in > display-line-numbers.el and the variables in cus-start.el can still use > it without display-line-numbers.el being preloaded. > > Which file would you rather have it in? All else being equal, I think having as much as possible in display-line-numbers.el would be better, as it avoids scattering related stuff across different files. Thanks.