From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Thu, 15 Feb 2018 18:22:42 +0200 Message-ID: <83h8qiw7cd.fsf@gnu.org> References: <1775923222.898447.1518559575706@mail.libero.it> <83inb0xkfx.fsf@gnu.org> <87o9krdftc.fsf@gmail.com> <83a7wby1x4.fsf@gnu.org> <83r2pnwftj.fsf@gnu.org> <08ac43fb-0b13-8a51-4571-11a21b8ffbdc@dancol.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1518711704 27254 195.159.176.226 (15 Feb 2018 16:21:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Feb 2018 16:21:44 +0000 (UTC) Cc: rpluim@gmail.com, emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 15 17:21:39 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emMHl-00062M-Vx for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 17:21:26 +0100 Original-Received: from localhost ([::1]:36174 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emMJn-0003jM-UC for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 11:23:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emMJ7-0003ir-Um for emacs-devel@gnu.org; Thu, 15 Feb 2018 11:22:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emMJ3-0000H5-T1 for emacs-devel@gnu.org; Thu, 15 Feb 2018 11:22:49 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emMJ3-0000Gz-Oc; Thu, 15 Feb 2018 11:22:45 -0500 Original-Received: from [176.228.60.248] (port=2337 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1emMJ3-0008I5-9F; Thu, 15 Feb 2018 11:22:45 -0500 In-reply-to: <08ac43fb-0b13-8a51-4571-11a21b8ffbdc@dancol.org> (message from Daniel Colascione on Wed, 14 Feb 2018 11:26:37 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222763 Archived-At: > Cc: rpluim@gmail.com, emacs-devel@gnu.org > From: Daniel Colascione > Date: Wed, 14 Feb 2018 11:26:37 -0800 > > >> It's weird that we're failing there. If we're looking at a buffer with > >> dumped contents, we set b->text->beg to NULL, then use the normal > >> buffer-allocation procedure (whichever we're compiled to use) to > >> allocate memory for the contents. How can the resulting address ever be > >> equal to what we started with? Neither mmap_realloc nor r_re_alloc nor > >> xrealloc should ever reuse the address. > > > > You are talking about what enlarge_buffer_text does? IOW, this: > > It should be fixed now. Give it a shot. Thanks, the problem is indeed fixed, and with that I was able to successfully complete the bootstrap. I also tested an optimized build, and a parallel "make -j8" build, and they all worked as expected. The times to load the .pdmp file are around 20 msec for an unoptimized build and 7 msec for an optimized build, which I think is very impressive. For the record, this is a 32-bit MinGW build configured with "--with-large-int --with-modules --enable-checking", on a 3-year old Core i7 box running Windows 7.