From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Identifying the face between STRETCH and right fringe. Date: Wed, 28 Nov 2018 09:13:36 +0200 Message-ID: <83h8g1fzdr.fsf@gnu.org> References: <83h8gbis2d.fsf@gnu.org> <83zhu0f6tt.fsf@gnu.org> <83sgzrgb1f.fsf@gnu.org> <83r2fbg5bq.fsf@gnu.org> <83lg5jfs9o.fsf@gnu.org> <83a7luhnid.fsf@gnu.org> <838t1ehi6v.fsf@gnu.org> <831s76gxkq.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1543389117 19867 195.159.176.226 (28 Nov 2018 07:11:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Nov 2018 07:11:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 28 08:11:53 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRu0m-00054m-Kz for ged-emacs-devel@m.gmane.org; Wed, 28 Nov 2018 08:11:52 +0100 Original-Received: from localhost ([::1]:46326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRu2t-0007A3-8R for ged-emacs-devel@m.gmane.org; Wed, 28 Nov 2018 02:14:03 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRu2L-00078o-0t for emacs-devel@gnu.org; Wed, 28 Nov 2018 02:13:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRu2H-0004XL-Ts for emacs-devel@gnu.org; Wed, 28 Nov 2018 02:13:29 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRu2H-0004WF-P8; Wed, 28 Nov 2018 02:13:25 -0500 Original-Received: from [176.228.60.248] (port=3675 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gRu2H-0004jR-C9; Wed, 28 Nov 2018 02:13:25 -0500 In-reply-to: (message from Robert Pluim on Tue, 27 Nov 2018 20:14:14 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231475 Archived-At: > From: Robert Pluim > Cc: emacs-devel@gnu.org > Date: Tue, 27 Nov 2018 20:14:14 +0100 > > >> > Why does NS use indices here, and not RGBA values? > >> > >> Probably because NS doesnʼt really use the RGBA values directly at > >> all, but uses the indices all the time. > > > > So where does the RGBA value in FRAME_BACKGROUND_PIXEL come from? Can you answer this question? > I love those rare moments when I implement something one way, and then > Eli tells me to do it that way :-) > > In theory there are a couple of other fields in the face structure > that might need the same type of treatment, but I didnʼt see any code > comparing them to RGBA pixel values. > > I suck at naming things, comments welcome. LGTM, thanks. Let's wait for comments from NS people. > - && face->background == FRAME_BACKGROUND_PIXEL (f) > + && FACE_COLOR_TO_PIXEL(face->background, f) == FRAME_BACKGROUND_PIXEL (f) ^ Please leave one space between the macro name and the opening paren.