From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Date: Tue, 29 Jan 2019 18:54:46 +0200 Message-ID: <83h8dr2yll.fsf@gnu.org> References: <20190128152540.6870.46132@vcs0.savannah.gnu.org> <20190128152541.12A4D20B50@vcs0.savannah.gnu.org> <30bm401x64.fsf@fencepost.gnu.org> <83r2cw35jq.fsf@gnu.org> <83munk33gj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="240928"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 29 17:56:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goWg5-0010Uj-Jt for ged-emacs-devel@m.gmane.org; Tue, 29 Jan 2019 17:56:01 +0100 Original-Received: from localhost ([127.0.0.1]:52289 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goWg4-0003EW-Fw for ged-emacs-devel@m.gmane.org; Tue, 29 Jan 2019 11:56:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goWf9-0002hQ-Hj for emacs-devel@gnu.org; Tue, 29 Jan 2019 11:55:04 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goWf3-0002An-Sr; Tue, 29 Jan 2019 11:54:59 -0500 Original-Received: from [176.228.60.248] (port=2499 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1goWf2-0001ZN-J4; Tue, 29 Jan 2019 11:54:57 -0500 In-reply-to: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Mon, 28 Jan 2019 21:38:29 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232789 Archived-At: > From: João Távora > Date: Mon, 28 Jan 2019 21:38:29 +0000 > Cc: emacs-devel > > But really, is there a list of reserved symbols somewhere? Not that I'm aware of. But I added to the manual the description of the role of the 'face' property of the face synbol. > And if this is reserved for presumably "internal" purposes, couldn't > that symbol be renamed to 'internal--face-id' or something like > that? Or are there too many references? It's too late for that, I think. Instead, packages should IMO try to keep the global namespace clean in the property domain as well, thus defining properties whose names have the prefix of the package name. > > > Wouldn't another (perhaps uglier, but easier) fix amount to renaming the > > > face 'flymake-error-face'? > > Not sure how that would help in this matter. > > As far as I can understand, this is because flymake-error, the flymake error > type, is conflated with flymake-error, the face. No, the problem is that each face has its numeric face ID stored as the value of the face symbol's 'face' property. So, no matter what is the face symbol, its 'face' property should not be touched.