From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 1072155: Avoid duplicate entries in process-environment after re-dumping Date: Wed, 03 Apr 2019 12:22:23 +0300 Message-ID: <83h8bfe94g.fsf@gnu.org> References: <20190321155613.6127.22574@vcs0.savannah.gnu.org> <20190321155614.E6343209B2@vcs0.savannah.gnu.org> <892097f7bc3f5e0ac88d31c60e0bed59.squirrel@dancol.org> <834l7gfbxn.fsf@gnu.org> <369aae77db760bfe079e47254470001d.squirrel@dancol.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="24162"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: "Daniel Colascione" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 03 11:22:19 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBc67-0006AR-2t for ged-emacs-devel@m.gmane.org; Wed, 03 Apr 2019 11:22:19 +0200 Original-Received: from localhost ([127.0.0.1]:36700 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBc65-0004fb-S4 for ged-emacs-devel@m.gmane.org; Wed, 03 Apr 2019 05:22:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBc5z-0004fH-4O for emacs-devel@gnu.org; Wed, 03 Apr 2019 05:22:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBc5y-000821-G6; Wed, 03 Apr 2019 05:22:10 -0400 Original-Received: from [176.228.60.248] (port=2640 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hBc5x-0005P5-Ty; Wed, 03 Apr 2019 05:22:10 -0400 In-reply-to: <369aae77db760bfe079e47254470001d.squirrel@dancol.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234914 Archived-At: > Date: Tue, 2 Apr 2019 13:11:53 -0700 > From: "Daniel Colascione" > Cc: "Daniel Colascione" , > emacs-devel@gnu.org > > >> Don't we want to reset process-environment to its old value in > >> dump_unwind_cleanup? > > > > You are thinking about re-dumping from an interactive session? > > Yes > > > In > > that case, probably yes. But currently we only support dumping from > > batch sessions, and in that case I don't see a need to restore > > process-environment, am I missing something? > > We "support" dumping only from dedicated batch instances in that for now > we should consider only bugs in that use case release-blocking, but I > don't want to gratuitously break other use cases like dumping interactive > sessions without killing them, since these use cases are meant to work and > we'll give them the same level of support someday soon. OK, but is there any reason dump_unwind_cleanup doesn't restore post-gc-hook? Omission?