From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Extend gdb to filter registers Date: Sun, 19 Jan 2020 22:07:21 +0200 Message-ID: <83h80rxlae.fsf@gnu.org> References: <878spmuerf.fsf@mail.linkov.net> <83wod3bx8i.fsf@gnu.org> <9f5ddaa5-0234-a17b-bdd7-81d70a0a50d6@gmx.at> <83FFF194-64CD-409E-8B7A-5A9DF91E79DE@gmail.com> <83v9pb314t.fsf@gnu.org> <838sm510d6.fsf@gnu.org> <83muakzoy5.fsf@gnu.org> <71042c9f-478b-47c8-f27e-1348e9f4536d@gmx.at> <83iml8zkbm.fsf@gnu.org> <6ad85759-7408-f177-38f6-45a72c2f5a9e@gmx.at> <83eevwzi79.fsf@gnu.org> <68ef651e-9319-b392-af1c-4564d5db9112@gmx.at> <831rrvzc81.fsf@gnu.org> <997C9AD2-D8DD-45DC-9195-28FEC907B2C4@gmail.com> <83muajxs04.fsf@gnu.org> <416593FF-C4BE-478F-B5AC-3379235146ED@gmail.com> <83lfq3xp66.fsf@gnu.org> <679953AF-F50A-4ABE-B836-150BA0F95DAE@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="23916"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, emacs-devel@gnu.org, monnier@iro.umontreal.ca, john@yates-sheets.org, juri@linkov.net To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 19 21:07:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1itGrU-0006BP-Gu for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Jan 2020 21:07:56 +0100 Original-Received: from localhost ([::1]:53250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itGrT-0002Lc-J9 for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Jan 2020 15:07:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40490) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itGqv-0001rX-IK for emacs-devel@gnu.org; Sun, 19 Jan 2020 15:07:22 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1itGqt-0006tn-RJ; Sun, 19 Jan 2020 15:07:19 -0500 Original-Received: from [176.228.60.248] (port=2464 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1itGqr-0006oI-4u; Sun, 19 Jan 2020 15:07:19 -0500 In-reply-to: <679953AF-F50A-4ABE-B836-150BA0F95DAE@gmail.com> (message from Yuan Fu on Sun, 19 Jan 2020 14:35:49 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244394 Archived-At: > From: Yuan Fu > Date: Sun, 19 Jan 2020 14:35:49 -0500 > Cc: martin rudalics , > Juri Linkov , > emacs-devel@gnu.org, > monnier@iro.umontreal.ca, > john@yates-sheets.org > > But do we have any control on whether gdb-display-source-buffer will > find a source window where we want it to? I'm not sure. > > I don’t quite understand. gdb-display-source-buffer finds source window when there is one. What do you > mean by “control” and “where we want it to”? I mean when gdb-display-source-buffer will fail to find the source window? > It shouldn't harm to try that. I'd still make it optional - maybe > someone wants to see the other buffers. > > I tend to agree with the last bit. > > At the very least I want to fix the inconsistency in gdb-mi — goto-breakpoint uses `(or > gdb-display-source-buffer display-buffer)` and gud-display-line uses `display-buffer`. We can modify the > display logic to allow user customization once gdb-mi is consistent within itself. Let's add a defcustom to control this new behavior.