From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: pull requests Date: Fri, 27 Mar 2020 16:30:29 +0300 Message-ID: <83h7ya7wne.fsf@gnu.org> References: <87mu87ji39.fsf@dick> <87v9mvp2ms.fsf@blind.guru> <87d093f6lj.fsf@dick> <87369yc79r.fsf@dick> <83mu828c7d.fsf@gnu.org> <7b0e82fd-8928-26d2-4bed-331593685f36@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="90225"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 27 14:31:31 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jHp58-000NOK-OW for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Mar 2020 14:31:30 +0100 Original-Received: from localhost ([::1]:41786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHp57-0005xv-Rx for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Mar 2020 09:31:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45206) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHp4H-0005Op-8r for emacs-devel@gnu.org; Fri, 27 Mar 2020 09:30:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jHp4H-00078j-2p; Fri, 27 Mar 2020 09:30:37 -0400 Original-Received: from [176.228.60.248] (port=3485 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jHp4E-0001Wv-8T; Fri, 27 Mar 2020 09:30:36 -0400 In-Reply-To: <7b0e82fd-8928-26d2-4bed-331593685f36@gmail.com> (message from =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel on Fri, 27 Mar 2020 09:00:10 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245837 Archived-At: > From: Clément Pit-Claudel > Date: Fri, 27 Mar 2020 09:00:10 -0400 > > On 27/03/2020 03.54, Eli Zaretskii wrote: > > More importantly, given that I did a review > > of such a remote branch, how do I communicate my comments so that they > > are recorded for posterity? Probably by email, so that doesn't seem > > to solve the main problem of avoiding email in the patch submission > > and review workflow. > > Assuming you use the web UI, you can typically attach comments to code regions. And how does one point to such past discussions, or more generally make sure they end up in some centralized place we could later revisit?