Re: master 4d00db5 8/8: Remove compat code from comint.el

Re: master 4d00db5 8/8: Remove compat code from comint.el

[Basil L. Contovounesios]

larsi@gnus.org (Lars Ingebrigtsen) writes:

> branch: master
> commit 4d00db5538dc0ef47cf1cdf425b895d04145fe9e
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Remove compat code from comint.el
>     
>     * lisp/comint.el (make-comint-in-buffer): `start-file-process' is
>     always defined, so remove test.
> ---
>  lisp/comint.el | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/lisp/comint.el b/lisp/comint.el
> index df947b9..843cba1 100644
> --- a/lisp/comint.el
> +++ b/lisp/comint.el
> @@ -735,8 +735,6 @@ contents are sent to the process as its initial input.
>  If PROGRAM is a string, any more args are arguments to PROGRAM.
>  
>  Return the (possibly newly created) process buffer."
> -  (or (fboundp 'start-file-process)
> -      (error "Multi-processing is not supported for this system"))
>    (setq buffer (get-buffer-create (or buffer (concat "*" name "*"))))
>    ;; If no process, or nuked process, crank up a new one and put buffer in
>    ;; comint mode.  Otherwise, leave buffer and existing process alone.

Perhaps the code here and in the previous commit meant to check for
(fboundp 'make-process) instead?  start-file-process may always be
defined, but I don't recall all platforms supporting subprocesses.  Or
is this check no longer deemed necessary?

Thanks,

-- 
Basil

Re: master 4d00db5 8/8: Remove compat code from comint.el

[Lars Ingebrigtsen]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

>>  Return the (possibly newly created) process buffer."
>> -  (or (fboundp 'start-file-process)
>> -      (error "Multi-processing is not supported for this system"))

[...]

> Perhaps the code here and in the previous commit meant to check for
> (fboundp 'make-process) instead?  start-file-process may always be
> defined, but I don't recall all platforms supporting subprocesses.  Or
> is this check no longer deemed necessary?

Yeah, that makes more sense.  There was an equivalent check in
esh-proc.el that added a lot of code to the non-start-file-process case
that made me wonder, too.

I guess there's still platforms without subprocess support?  DOS?  Or is
that deprecated?  If so, this patch (and the esh-proc.el patch) should
be reverted and the checks changed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 4d00db5 8/8: Remove compat code from comint.el

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 12 Aug 2020 13:03:09 +0200
> Cc: emacs-devel@gnu.org
> 
> I guess there's still platforms without subprocess support?  DOS?

Yes, that's the only one.

Re: master 4d00db5 8/8: Remove compat code from comint.el

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> I guess there's still platforms without subprocess support?  DOS?
>
> Yes, that's the only one.

OK, I'll revert the two affected patches and check for the correct
function instead.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no