unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: master 388a874 2/4: Do interactive mode tagging for man.el
Date: Sat, 20 Feb 2021 09:39:41 +0200	[thread overview]
Message-ID: <83h7m71936.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmmJybbOV+Mm9yBuOGeTpFrxrPaZpTkw67N9Enf0hxMXHQ@mail.gmail.com> (message from Stefan Kangas on Fri, 19 Feb 2021 20:24:49 -0600)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 19 Feb 2021 20:24:49 -0600
> Cc: emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Stefan, did you consider the fact that woman.el defines a different
> > mode, but uses some commands from man.el?  (I didn't try invoking the
> > commands you tagged, so maybe there's no problem.)
> 
> Thanks for catching this.

So I think the procedure for tagging should include a mandatory
grepping of all the Lisp files to see if the mode or its features are
referenced or used anywhere else.

> So if we want to keep the tagging, I see two possible workarounds:
> 
> 1) Tag the man-mode commands with both `Man-mode' and `woman-mode'.
> 
> 2) Introduce a new mode, `man-shared-mode', inheriting from
>    special-mode, that both `Man-mode' and `woman-mode' can inherit
>    from.  Then tag the commands using that.
> 
> Both options have their pros and cons.

There's a 3rd option:

 3) Put a 'completion-predicate' property on the relevant woman.el
    commands, so that command-completion-default-include-p does TRT
    with them even though the modes don't match.

I will withhold my opinion for now, and let Lars and others speak up.
This is basically the first time we bump into the issues that were
discussed here already, but sounded theoretical back then.  We now
need to fix such an issue with the tagging in practice, and we might
as well invest some thinking before we decide which way to go.
Because whatever we decide to do now, and the considerations to go
into that decision, will be most probably taken as the canonical
solution for such situations.



  reply	other threads:[~2021-02-20  7:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19 15:56 master 388a874 2/4: Do interactive mode tagging for man.el Eli Zaretskii
2021-02-20  2:24 ` Stefan Kangas
2021-02-20  7:39   ` Eli Zaretskii [this message]
2021-02-20 12:26     ` Lars Ingebrigtsen
2021-02-20 12:56       ` Eli Zaretskii
2021-02-20 12:23   ` Lars Ingebrigtsen
2021-02-21 10:37     ` Stefan Kangas
2021-02-21 15:48       ` Lars Ingebrigtsen
2021-02-21 19:18         ` Stefan Kangas
2021-02-21 17:43       ` Eli Zaretskii
2021-02-21 19:03         ` Stefan Kangas
2021-02-22 22:34       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h7m71936.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).