From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Consistent face for keys in *Help* and `substitute-command-keys' Date: Sun, 07 Mar 2021 09:42:21 +0200 Message-ID: <83h7lntnoi.fsf@gnu.org> References: <831rd4romg.fsf@gnu.org> <83zgzsq7xn.fsf@gnu.org> <83v9afriqp.fsf@gnu.org> <83zgzjhvdn.fsf@gnu.org> <83a6rhxwah.fsf@gnu.org> <837dmlxspt.fsf@gnu.org> <834khpxr0s.fsf@gnu.org> <8335x8ybw9.fsf@gnu.org> <83mtvguog6.fsf@gnu.org> <83mtvftqb0.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11255"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 07 08:43:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIo4C-0002pc-2a for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Mar 2021 08:43:08 +0100 Original-Received: from localhost ([::1]:60872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIo4B-0007I9-54 for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Mar 2021 02:43:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIo3c-0006pE-7Y for emacs-devel@gnu.org; Sun, 07 Mar 2021 02:42:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54273) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIo3b-0005Rw-FV; Sun, 07 Mar 2021 02:42:31 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4656 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lIo3a-0001BE-Fl; Sun, 07 Mar 2021 02:42:31 -0500 In-Reply-To: (message from Stefan Kangas on Sun, 7 Mar 2021 02:26:27 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266118 Archived-At: > From: Stefan Kangas > Date: Sun, 7 Mar 2021 02:26:27 -0500 > Cc: larsi@gnus.org, emacs-devel@gnu.org > > Eli Zaretskii writes: > > >> It's just to make them alphabetical. > > > > That's what I thought, but then "q" is out of order, isn't it? > > Sure. I left it as it seemed to have been intentionally placed at the > end -- the quit command is "special". But I don't have any strong > preferences here, so please let me know if you want something changed. Up to you, it's really a nit that isn't worth arguing about. > > I'm not sure it's a good idea. "M-x foobar" is not a key sequence in > > the sense we use it for this feature, I think. This feature is not > > about displaying any key sequence in any context, it's about > > displaying them in the context of help-related text. > > My thinking here is that the face should separate "anything that the > user could type to run a command" from the surrounding body text. In > this sense, there is no strong difference between an unbound command and > an actual keybinding. It just seems more helpful. > > I don't see any obvious problems with this approach, but perhaps there > is something that I'm overlooking. > > BTW, there was a bug in the above code where only the "M-x" part was > fontified, now fixed: Fine with me, thanks.