From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: gabriel376@hotmail.com, stefankangas@gmail.com, emacs-devel@gnu.org
Subject: Re: Little improvements on pulse.el
Date: Wed, 10 Mar 2021 21:11:28 +0200 [thread overview]
Message-ID: <83h7liomcf.fsf@gnu.org> (raw)
In-Reply-To: <87mtvan8oi.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 10 Mar 2021 20:51:57 +0200)
> From: Juri Linkov <juri@linkov.net>
> Cc: Gabriel <gabriel376@hotmail.com>, Eli Zaretskii <eliz@gnu.org>,
> emacs-devel@gnu.org
> Date: Wed, 10 Mar 2021 20:51:57 +0200
>
> BTW, currently 'pulse-momentary-highlight-one-line'
> has no visible indication on an empty line, so it's face
> should be fixed to have the face attribute :extend t.
I disagree with doing this unconditionally. Current uses of this face
don't need to show empty lines, so adding that attribute would
gratuitously change previous behavior.
Commands that want to use this for potentially empty lines can always
produce a derived face if they so want.
next prev parent reply other threads:[~2021-03-10 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 5:39 Little improvements on pulse.el Gabriel
2021-03-10 12:13 ` Eli Zaretskii
2021-03-10 13:41 ` Stefan Kangas
2021-03-10 17:18 ` Juri Linkov
2021-03-10 18:51 ` Juri Linkov
2021-03-10 19:11 ` Eli Zaretskii [this message]
2021-03-11 23:42 ` Gabriel
2021-03-12 7:29 ` Eli Zaretskii
2021-03-10 18:59 ` Juri Linkov
2021-03-11 15:35 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h7liomcf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gabriel376@hotmail.com \
--cc=juri@linkov.net \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).