From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Sat, 24 Jul 2021 08:52:42 +0300 Message-ID: <83h7gk1cnp.fsf@gnu.org> References: <83h7gw6pyj.fsf@gnu.org> <45EBF16A-C953-42C7-97D1-3A2BFEF7DD01@gmail.com> <83y2a764oy.fsf@gnu.org> <83v95b60fn.fsf@gnu.org> <00DD5BFE-D14E-449A-9319-E7B725DEBFB3@gmail.com> <83r1fz5xr9.fsf@gnu.org> <1AAB1BCC-362B-4249-B785-4E0530E15C60@gmail.com> <83czri67h0.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <8335s64v10.fsf@gnu.org> <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> <83k0li2shw.fsf@gnu.org> <83eebq2mpy.fsf@gnu.org> <83lf5w26e3.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22554"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: "Perry E. Metzger" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 24 07:53:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7AbT-0005hq-EP for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 07:53:39 +0200 Original-Received: from localhost ([::1]:33070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7AbR-000453-Tl for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 01:53:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Aar-0003PL-CO for emacs-devel@gnu.org; Sat, 24 Jul 2021 01:53:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59292) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7Aaq-0001qL-Qz; Sat, 24 Jul 2021 01:53:00 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4835 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Aaq-0006bx-Ei; Sat, 24 Jul 2021 01:53:00 -0400 In-Reply-To: (perry@piermont.com) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271522 Archived-At: > Date: Fri, 23 Jul 2021 16:01:14 -0400 > From: "Perry E. Metzger" > > On 7/23/21 15:10, Eli Zaretskii wrote: > > >> Abort, it seems: > >> static inline void *ts_malloc_default(size_t size) { > >> void *result = malloc(size); > >> if (size > 0 && !result) { > >> fprintf(stderr, "tree-sitter failed to allocate %zu bytes", size); > >> exit(1); > >> } > >> return result; > >> } > > We must replace this function, if only because the MS-Windows build of > > Emacs uses a custom malloc implementation. Does TS allow the client > > to use its own malloc? > > Certainly more graceful allocation error behavior would be necessary in > an Emacs context even on Unix-like operating systems. An unexpected hard > exit could result in loss of data for the user. Sure, which is why this must be replaced.