From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-28 6170c50: Fix regression in help-mode prompt Date: Tue, 14 Dec 2021 15:09:06 +0200 Message-ID: <83h7bbl4el.fsf@gnu.org> References: <20211213135228.14462.36839@vcs0.savannah.gnu.org> <20211213135230.17FE620A0A@vcs0.savannah.gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22214"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 14 14:21:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mx7k8-0005UD-1v for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Dec 2021 14:21:20 +0100 Original-Received: from localhost ([::1]:41082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mx7k6-0006Zn-LT for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Dec 2021 08:21:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mx7YZ-0003js-5L for emacs-devel@gnu.org; Tue, 14 Dec 2021 08:09:23 -0500 Original-Received: from [2001:470:142:3::e] (port=37366 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mx7YY-0000Rz-Q5; Tue, 14 Dec 2021 08:09:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MJTO8/rAs+xk5/GjwW3wjHkUgcVULPyDjc+i92HN6JQ=; b=hlZ5+a3CF3Rg r1NoBAzi7d7DDXSsF5zWIzNeqZKpyFc3Bui32mDzqSTDJweMLcf8lWQE/AWtCoBfarJKOPz8D8Nst MmY1SA0BHG5i9N82/yNODiy24APA+hSv52WGVQM7OVmJNWWmS3bx8U67n6eJ76g/cJsXKE0oL594u nTCp4Ub3nW/a68OuL2gFfwWvgsv1pbcUXOoWq8IHL/UgQunJzI4j9v8+OGZ9xOimsJRWu8DPwa7Lw Ol2si8ooS5MRxB2j9ekH7OmWk+LDZBSf0cWnXrOix34lRGbKpn3KS/PUK36XMU9bfACyJ6Wv9/1Gp 2+bnN6mFszcgsr/AEV1fzA==; Original-Received: from [87.69.77.57] (port=4319 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mx7YK-00062h-RB; Tue, 14 Dec 2021 08:09:15 -0500 In-Reply-To: (message from Stefan Kangas on Tue, 14 Dec 2021 03:30:22 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281894 Archived-At: > From: Stefan Kangas > Date: Tue, 14 Dec 2021 03:30:22 -0800 > > eliz@gnu.org (Eli Zaretskii) writes: > > > diff --git a/lisp/help-macro.el b/lisp/help-macro.el > > index 1fa9d82..b3c7e23 100644 > > --- a/lisp/help-macro.el > > +++ b/lisp/help-macro.el > > @@ -165,14 +165,18 @@ and then returns." > > (let ((cursor-in-echo-area t) > > (overriding-local-map local-map)) > > (setq key (read-key-sequence > > - (format "Type one of the options listed%s: " > > + (format "Type one of listed options%s: " > > Are we sure that this is an improvement? I find the old text more natural. I didn't change the text to improve it, I changed it to make it shorter. Because otherwise, when we echo the keys typed by the user, they overflow the (default) window width, and that resizes the mini-window, which causes an unpleasant effect of scrolling the Help window. If you can suggest a different solution that avoids the resizing, please do.