From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix placement of toggle and radio button in Lucid menu. Date: Fri, 25 Feb 2022 14:18:49 +0200 Message-ID: <83h78nqguu.fsf@gnu.org> References: <87sfs87i5o.fsf@elite.giraud> <87pmnc7f5c.fsf@yahoo.com> <87k0dk7ejd.fsf@yahoo.com> <878rtzb3hr.fsf@elite.giraud> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16831"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, emacs-devel@gnu.org To: Manuel Giraud Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 25 13:20:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNZaT-00048P-Dz for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Feb 2022 13:20:41 +0100 Original-Received: from localhost ([::1]:58232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNZaR-0000ha-Sf for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Feb 2022 07:20:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNZYQ-0008Im-CL for emacs-devel@gnu.org; Fri, 25 Feb 2022 07:18:34 -0500 Original-Received: from [2001:470:142:3::e] (port=50846 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNZYP-0005nH-BQ; Fri, 25 Feb 2022 07:18:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=r+21c3MAkvUTWRwxudfhqGnkwyruyLNG9wpaPnYiY+Q=; b=c+X2BL/Sy/RN 6ZnXYkKqj7g0T22jFO0VzKe7Vp3HhxZ0hwnl/HbqsqLO+bvJ34QHeBUPJVZ/1Fz9CTAHV9+4D8BoD DDj2EIpgZacA3ZAYURhempCkjCwXyU79d71rqcokggq860jJoO/9cZuBKxB2Ea4ndXBC2zi55X3RW s8LBN3NhJijuxh5ifIT6v/yD56vrs4JEz+5G1GPd9s10K6ZJsAr2Z/tK/PZvAwa0DhGKOTOfI1BK0 SSnWo1iHtIiFsRzEp0H5dGf6tgiASHvEZA5n+3iE/3bQX56APRiv5BCT01fsSZG5UryEYtElky0Te j1ESmMH3jI17qW6AAeX16g==; Original-Received: from [87.69.77.57] (port=4508 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNZYO-0008MP-Qh; Fri, 25 Feb 2022 07:18:33 -0500 In-Reply-To: <878rtzb3hr.fsf@elite.giraud> (message from Manuel Giraud on Fri, 25 Feb 2022 12:16:32 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286679 Archived-At: > From: Manuel Giraud > Date: Fri, 25 Feb 2022 12:16:32 +0100 > Cc: emacs-devel > > Ok so here is a new patch that I think fixes this issue. The first line > of the patch sets the toggle to size to be 2/3 of the ascent (and not > height) of the font: it seems more logical if those buttons resides on > the baseline. Can we please take a step back and try to understand the issue better? I asked a question in this thread; can we have an answer to that question? Basically, I don't understand why the original code doesn't appear to do its job as intended. If you do understand, please post a detailed explanation of the reason. Once we understand the reason(s), we can discuss solutions. Thanks.