From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 5743b74d4b 1/2: Improve mouse dragging Date: Thu, 12 May 2022 16:12:10 +0300 Message-ID: <83h75uq4id.fsf@gnu.org> References: <83sfpfp5p1.fsf@gnu.org> <87sfpfx8j8.fsf@yahoo.com> <83ilqaq5o9.fsf@gnu.org> <87fsleykdp.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12308"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 12 15:13:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1np8dR-00033Q-0w for ged-emacs-devel@m.gmane-mx.org; Thu, 12 May 2022 15:13:41 +0200 Original-Received: from localhost ([::1]:49004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1np8dP-00056z-IZ for ged-emacs-devel@m.gmane-mx.org; Thu, 12 May 2022 09:13:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np8bw-0001qD-N3 for emacs-devel@gnu.org; Thu, 12 May 2022 09:12:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35938) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np8bw-0004qD-Bp; Thu, 12 May 2022 09:12:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vjc57AO0h0RdGWYUOsJK7ndqxcZ5eE9OsafwGdAn83Q=; b=pVL/AvrQMskz rmEEu6QnWbqHOYBuA3cu5KreYjcXXPzQ/uRZHQM8GCRcWtHnHkcNaYRnaH3jHPQUi2KAF2t8NCN+N 3VkE9zl0tvF2rjtxc8zQIpcV81DFcAYqCNtBl7DeQBl7tZJ2llscljvBsQeEajXtB45A3a8zRvW+U 8vnvBmxxCcmNSQ3A9JqFjJWu3jLrlJ75lDXC5PzlDGTmG5RVu8C7TMIFagdD4OT3H0adFAZd8M/mB 3PHhvnakcCZW27H1ij2LbGWIP+Kn9yuiax4GJYsEugmDAgJgRul49nCfDM7XomA3IdfDaYb8F0e/q bJdb9y5QuV1z1s2pruX+qw==; Original-Received: from [87.69.77.57] (port=1443 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np8bv-0005Ej-9L; Thu, 12 May 2022 09:12:08 -0400 In-Reply-To: <87fsleykdp.fsf@yahoo.com> (message from Po Lu on Thu, 12 May 2022 21:02:10 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289684 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Thu, 12 May 2022 21:02:10 +0800 > > Eli Zaretskii writes: > > > Why are they not respected? I see the correct colors in the tooltips > > in Emacs 28, so it does seem to work. What am I missing? > > We used to use `tooltip-show' directly in Emacs 28, but that function > modifies the text properties of `text-tooltip', which caused mouse > dragging to drag along some undesirable text properties. "Used to use"? And now we don't? But your changes are in tooltip-show, so if we don't use it anymore, why the changes? Could you possibly post a more detailed response, one which would explain that change starting from how this stuff behaves in Emacs 28 and why we needed to change it in Emacs 29, without omitting any crucial details?