From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: xref-query-replace-in-results error message after xref-find-definitions, was: Re: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful
Date: Tue, 11 Oct 2022 19:50:44 +0300 [thread overview]
Message-ID: <83h70ae23f.fsf@gnu.org> (raw)
In-Reply-To: <c3f53595-8f69-ebb5-7ac2-e3c86f1b5817@yandex.ru> (message from Dmitry Gutov on Tue, 11 Oct 2022 19:41:35 +0300)
> Date: Tue, 11 Oct 2022 19:41:35 +0300
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
>
> >> This would do nothing for custom values of
> >> xref-show-definitions-function, but should remove most of the confusion
> >> with default configuration. And some non-default ones as well (lsp-mode
> >> doesn't change the value of xref-show-definitions-function).
> >>
> >> If the docstring of xref-show-definitions-function looks okay to you, we
> >> can use its vocabulary.
> >>
> >> Cannot replace in definition search results
> >>
> >> should cover xref-find-definitions, lsp-find-definition and
> >> lsp-find-declaration. Wouldn't help with lsp-find-implementation, though
> >> (its results are also questionable WRT renaming because they don't
> >> include all references either), but it won't make it worse.
> >
> > Hmm... maybe
> >
> > Cannot perform global replacement in find-definition results
> >
> > Another idea would be for the error message to be constructed
> > dynamically, and include the precise command that produced the Xref
> > buffer, if xref.el could record that in some buffer-local variable.
>
> I suppose it could. But then some backend (such as lsp or possibly
> eglot) might return 'definitions' results in format suitable for
> replacements, and that will mean that one can replace in
> xref-find-definitions's results, just with some backends but not others.
>
> And with that, the error message
>
> Cannot do global replacement using results of \\[xref-find-definitions]
>
> shown to the same user at a different time (perhaps when they're editing
> Elisp) will become a lie.
>
> And then, okay, we could try to add the name of the backend symbol to
> the error message as well, but it's much harder to capture that one,
> especially given that not every command using Xref output will go
> through xref-backend-functions (project-find-regexp is a counter-example).
So is this:
Cannot perform global replacement in find-definition results
the best that can be done? It sounds like no alternative is
significantly better.
next prev parent reply other threads:[~2022-10-11 16:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m28rm2oiiy.fsf@Mini.fritz.box>
[not found] ` <83h70qhez0.fsf@gnu.org>
[not found] ` <m28rm2u0ga.fsf@Mini.fritz.box>
[not found] ` <83edvuhaby.fsf@gnu.org>
[not found] ` <m2zgeisg1u.fsf@Mini.fritz.box>
[not found] ` <831qruh67o.fsf@gnu.org>
[not found] ` <m2o7uysdfl.fsf@Mini.fritz.box>
[not found] ` <83y1u2foli.fsf@gnu.org>
[not found] ` <jwvh70q9whx.fsf-monnier+emacs@gnu.org>
[not found] ` <m235cas1w2.fsf@Mini.fritz.box>
[not found] ` <m2y1u2qm9s.fsf@Mini.fritz.box>
[not found] ` <jwvfsg996o3.fsf-monnier+emacs@gnu.org>
[not found] ` <m2o7uxqvlx.fsf@Mini.fritz.box>
[not found] ` <83zgehe6iq.fsf@gnu.org>
[not found] ` <95113379-99d8-eba4-f980-a7fca11430d5@yandex.ru>
[not found] ` <834jwfmn5a.fsf@gnu.org>
[not found] ` <f3967957-a4b2-8a9b-ae9c-b18b59370541@yandex.ru>
[not found] ` <838rlohzeo.fsf@gnu.org>
[not found] ` <d07f076f-21bf-9ab5-5ebe-1bf3d9fb7df1@yandex.ru>
[not found] ` <83mta2g91p.fsf@gnu.org>
2022-10-11 11:36 ` xref-query-replace-in-results error message after xref-find-definitions, was: Re: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful Dmitry Gutov
2022-10-11 11:51 ` Eli Zaretskii
2022-10-11 12:10 ` Dmitry Gutov
2022-10-11 12:17 ` Eli Zaretskii
2022-10-11 12:44 ` Dmitry Gutov
2022-10-11 12:55 ` Eli Zaretskii
2022-10-11 14:55 ` Dmitry Gutov
2022-10-11 16:01 ` Eli Zaretskii
2022-10-11 16:41 ` Dmitry Gutov
2022-10-11 16:50 ` Eli Zaretskii [this message]
2022-10-11 20:31 ` Dmitry Gutov
2022-10-12 5:17 ` Eli Zaretskii
2022-10-12 10:06 ` John Yates
2022-10-12 10:17 ` Eli Zaretskii
[not found] ` <CAJnXXogKsM=gMTFi2NivDMHW4A3EBtBtsNDBV3o5vcu2xXfuvw@mail.gmail.com>
2022-10-12 13:21 ` Eli Zaretskii
2022-10-12 16:12 ` John Yates
2022-10-12 13:47 ` Dmitry Gutov
2022-10-12 14:05 ` Eli Zaretskii
2022-10-11 14:04 ` Stefan Monnier
2022-10-11 14:07 ` Stefan Monnier
2022-10-11 15:07 ` Dmitry Gutov
2022-10-11 15:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h70ae23f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).