unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] Restore font-lock-type-face for lisp mode &symbols
@ 2022-12-04  6:57 Tom Gillespie
  2022-12-04 17:52 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Gillespie @ 2022-12-04  6:57 UTC (permalink / raw)
  To: Emacs developers; +Cc: Lars Ingebrigtsen

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

Hi,
   I noticed that font locking for lisp and elisp &keywords changed.
Looks like it was a mistake, so here's a patch to restore the correct
face. Best!
Tom

[-- Attachment #2: 0001-Restore-font-lock-type-face-for-lisp-mode-symbols.patch --]
[-- Type: text/x-patch, Size: 1751 bytes --]

From ca10502328ce21c47b7eadb2dd01236084fa0873 Mon Sep 17 00:00:00 2001
From: Tom Gillespie <tgbugs@gmail.com>
Date: Sat, 3 Dec 2022 22:41:15 -0800
Subject: [PATCH] Restore font-lock-type-face for lisp mode &symbols

* lisp/emacs-lisp/lisp-mode.el (lisp-cl-font-lock-keywords-2)
(lisp-el-font-lock-keywords-2): Testore use of type face instead of
builtin face for &symbol keywords

This fixes what appears to be a copy paste error that changed the face
for common lisp and emacs lisp &symbol style keywords that was
introduced in a498e5f8301eeb3bf7b15136469449ab4c93b99a by restoring
the type face to font-lock-type-face as consistent with the comments.
---
 lisp/emacs-lisp/lisp-mode.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
index 7e39a77aed5..bf879158188 100644
--- a/lisp/emacs-lisp/lisp-mode.el
+++ b/lisp/emacs-lisp/lisp-mode.el
@@ -514,7 +514,7 @@ lisp-mode--search-key
           (0 font-lock-builtin-face))
          ;; ELisp and CLisp `&' keywords as types.
          (,(lambda (bound) (lisp-mode--search-key "&" bound))
-          (0 font-lock-builtin-face))
+          (0 font-lock-type-face))
          ;; ELisp regexp grouping constructs
          (,(lambda (bound)
              (catch 'found
@@ -567,7 +567,7 @@ lisp-mode--search-key
           (0 font-lock-builtin-face))
          ;; ELisp and CLisp `&' keywords as types.
          (,(lambda (bound) (lisp-mode--search-key "&" bound))
-          (0 font-lock-builtin-face))
+          (0 font-lock-type-face))
          ;; ELisp regexp grouping constructs
          ;; This is too general -- rms.
          ;; A user complained that he has functions whose names start with `do'
-- 
2.37.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Restore font-lock-type-face for lisp mode &symbols
  2022-12-04  6:57 [PATCH] Restore font-lock-type-face for lisp mode &symbols Tom Gillespie
@ 2022-12-04 17:52 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2022-12-04 17:52 UTC (permalink / raw)
  To: Tom Gillespie; +Cc: emacs-devel, larsi

> From: Tom Gillespie <tgbugs@gmail.com>
> Date: Sat, 3 Dec 2022 22:57:28 -0800
> Cc: Lars Ingebrigtsen <larsi@gnus.org>
> 
>    I noticed that font locking for lisp and elisp &keywords changed.
> Looks like it was a mistake, so here's a patch to restore the correct
> face. Best!

Thanks, I installed this on the emacs-29 branch.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-12-04 17:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-04  6:57 [PATCH] Restore font-lock-type-face for lisp mode &symbols Tom Gillespie
2022-12-04 17:52 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).