From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2c8b09b06e7: Fix crash on Windows 9X Date: Tue, 06 Dec 2022 16:28:30 +0200 Message-ID: <83h6y87gj5.fsf@gnu.org> References: <167029029523.21453.12133435240921985505@vcs2.savannah.gnu.org> <20221206013135.E2E2DC004BE@vcs2.savannah.gnu.org> <87fsdtnn8x.fsf@yahoo.com> <83r0xc7mf8.fsf@gnu.org> <87v8mon18x.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13934"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 06 15:29:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2Ywd-0003Gn-Bg for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Dec 2022 15:29:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2YwL-0005q8-Tx; Tue, 06 Dec 2022 09:28:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2YwG-0005mw-DD for emacs-devel@gnu.org; Tue, 06 Dec 2022 09:28:52 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2YwF-0006xa-Mw; Tue, 06 Dec 2022 09:28:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rLEK7fiEDMb6gjFKkBJ9KNUqD8TBV8Sy7dSEPHqWlt8=; b=WUdG22/J9M2z ww5vt6ud0IcM7y3VjAWbt0b5qgVCfzcG+CBk2SSh2z8zO1jKsENYgJt00CTMPqTRUFwTzO2N4xf+y s85m7ivgDukpOSVdcGOeswHdutS0pAp0o9RqCCENct/8FQtBqtKbwAiH3N7OwVMEY6+N2Xx0kHyJg OhZslmQOVYo5zWen9LEkBmZH6CEQ2rLKZ/65F6ZTaIb2c3IsMK2eMPYhTPhkrhyc013hPNbxoUFxu M96SQnXETeuzTpRN7Q0leKZP/8jYqlWJyLOZ2f1HPMmh1ScLDF0Onocj7ZRImna8BF+bLhgVDJb8K TpnLD5QCeNZxyNOZ2QLJww==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2Yw9-0008Ll-Ie; Tue, 06 Dec 2022 09:28:47 -0500 In-Reply-To: <87v8mon18x.fsf@yahoo.com> (message from Po Lu on Tue, 06 Dec 2022 20:51:58 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300968 Archived-At: > From: Po Lu > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Tue, 06 Dec 2022 20:51:58 +0800 > > Eli Zaretskii writes: > > >> No. The call I added is only called before dumping, while the second is > >> called after dumping, AFAIK. > > > > No, the second one is done both before and after dumping. Only the first > > call is conditioned. > > Ah, thanks for the clarification. In any case, it must come before > init_window_once. init_window_once is called only if (!initialized), so this order is only relevant for when dumping. > Does calling it twice hurt? It might, so I'd prefer not to risk such duplicate calls. It should be easy to make sure it is called only once when dumping for unexec, and only once in the pdumper build (both when dumping and when not dumping).