From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter navigation time grows as sqrt(line-number) Date: Fri, 01 Sep 2023 08:33:13 +0300 Message-ID: <83h6oecvae.fsf@gnu.org> References: <3E82D409-6903-4679-9031-939CA35791FF@gmail.com> <32507689-3b2c-ccbf-dd14-e7bf0bed1ac7@gutov.dev> <6db52945-5459-197c-405d-153ff395a824@gutov.dev> <1F7C956D-6D22-4CC1-8656-6E2A4D07D5FB@gmail.com> <69D18963-D94F-4792-9FF1-159897A99E50@gmail.com> <48CD64C5-CC2A-42C5-8496-33B188497B99@gmail.com> <831qfjg34v.fsf@gnu.org> <32BD183F-2E89-4EF4-B5D5-A3F9FE64178D@gmail.com> <83il8vc9pp.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9346"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, jdtsmith@gmail.com, dmitry@gutov.dev, emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 01 07:33:52 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbwn1-00028C-S5 for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Sep 2023 07:33:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbwmk-0000Kv-HE; Fri, 01 Sep 2023 01:33:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbwmh-00006L-2H for emacs-devel@gnu.org; Fri, 01 Sep 2023 01:33:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbwmg-0006wk-L0; Fri, 01 Sep 2023 01:33:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vfzK2wBgluvYzLPgOkMILecO/gvpOtIX6hiwE8qgo/I=; b=BB5h3dm8FB49 7CA5zZylQMZY92MnLzRC9U0YfWjGiG2vs2/zl1dKcgi+fVJz0/AP65hGBi5NVd7zT1CpbAy4/9sIa BWETlECFRliVy2EAocB4bEYbnRqmtvtJ066mMDq6aWXNukmimmXf2T2L9QPNVIgZpLgX3xdXeX3n1 73LVfHfAIO81Qz/SxrLhau3pCsfVvU19KcWpTA7IzITiCACHZ0M0s0oX3svgk4pIojaX+1iAJ4XrQ +Wrri2rPR+ibLl1p7RM+2fRTPP9dMtdhmV+9PSWWPCHsQpGqxwBS05uNHUDEEaTK0LsfFs2mfc7j8 VXK+zxYVms5j6W2cxzZCLQ==; In-Reply-To: (message from Stefan Kangas on Thu, 31 Aug 2023 22:24:03 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309720 Archived-At: > From: Stefan Kangas > Date: Thu, 31 Aug 2023 22:24:03 +0200 > Cc: Yuan Fu , jdtsmith@gmail.com, dmitry@gutov.dev, > emacs-devel@gnu.org > > Eli Zaretskii writes: > > > Stefan, WDYT about this? I admit I'm a bit weary, but everyone else > > seems to think this is a bugfix. > > I'm not sure I can be of much help here; I really haven't been > following treesitter development very closely. Having looked at the > patch, the fix is also slightly less trivial than I had hoped, in the > sense that I don't understand it. :-) > > That said, I do think that stability expectations might be a bit > different for a completely new and (arguably) semi-optional feature. > Yuan Fu's stated opinion up-thread was that the patch is "relatively > safe". > > If it was up to me, I'd probably keep it on emacs-29, with a readiness > to revert if any issues were to crop up. But I won't object either > way. OK, so let's keep it on emacs-29 and watch for any possible problems it could cause. Thanks.