From: Eli Zaretskii <eliz@gnu.org>
To: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
Cc: philipk@posteo.net, emacs-devel@gnu.org, stefankangas@gmail.com
Subject: Re: master 82cc1f4fda1: Revert use of seq-count in shr-count
Date: Wed, 06 Sep 2023 14:34:35 +0300 [thread overview]
Message-ID: <83h6o73584.fsf@gnu.org> (raw)
In-Reply-To: <87r0nccgp0.fsf@gmail.com> (message from Karthik Chikmagalur on Tue, 05 Sep 2023 17:02:03 -0700)
> From: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
> Cc: emacs-devel@gnu.org, stefankangas@gmail.com
> Date: Tue, 05 Sep 2023 17:02:03 -0700
>
> > I think we should start by measuring its actual performance as
> > compared to more "traditional" implementations. Then we will have the
> > base line and data for making the decisions.
>
> There are some benchmarks by Kisaragi Hiu comparing seq, cl-lib and dash
> on Emacs 28.1 here:
>
> https://kisaragi-hiu.com/performance-cl-lib-dash-seq/
>
> seq appears to be much slower than cl-lib.
Then I agree that we should convert to seq with caution, only where we
are sure that the slowdown won't matter much, and we should always
time the old vs the new code before making the decision.
next prev parent reply other threads:[~2023-09-06 11:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <169385595799.24305.652316651780689026@vcs2.savannah.gnu.org>
[not found] ` <20230904193238.46053C04DB0@vcs2.savannah.gnu.org>
2023-09-04 20:54 ` master 82cc1f4fda1: Revert use of seq-count in shr-count Philip Kaludercic
2023-09-05 2:34 ` Eli Zaretskii
2023-09-06 0:02 ` Karthik Chikmagalur
2023-09-06 11:34 ` Eli Zaretskii [this message]
2023-09-06 12:34 ` Eli Zaretskii
2023-09-06 22:21 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h6o73584.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=karthikchikmagalur@gmail.com \
--cc=philipk@posteo.net \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).