* Changes in callproc.c and term.c
@ 2009-07-03 14:40 Eli Zaretskii
0 siblings, 0 replies; only message in thread
From: Eli Zaretskii @ 2009-07-03 14:40 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: emacs-devel
Dan, I have a comment about this change committed today:
2009-07-03 Dan Nicolaescu <dann@ics.uci.edu>
* callproc.c (child_setup): Use #else instead of a separate #ifdef.
This change is perfectly okay syntactically and semantically, of
course. What bothers me is that it made two unrelated code snippets
look as if they do similar or related things on two different
platforms, because now they are in two sibling branches of the same
#ifdef.
However, this is a matter of style and personal preferences, so I'll
let Stefan and Yidong decide.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-07-03 14:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-03 14:40 Changes in callproc.c and term.c Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).