From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-21.1.94 crash in gnus on Windows Date: Thu, 25 Mar 2010 06:14:01 +0200 Message-ID: <83fx3pghrq.fsf@gnu.org> References: <84634x887o.fsf@gmail.com> <4B9F7F5F.1040504@gmail.com> <84eijkm21x.fsf@gmail.com> <87tys5be09.fsf@stupidchicken.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1269490483 20260 80.91.229.12 (25 Mar 2010 04:14:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 25 Mar 2010 04:14:43 +0000 (UTC) Cc: andrewjmoreton@gmail.com, schwab@linux-m68k.org, emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 25 05:14:39 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NueSr-0006rJ-RZ for ged-emacs-devel@m.gmane.org; Thu, 25 Mar 2010 05:14:38 +0100 Original-Received: from localhost ([127.0.0.1]:51393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NueSq-0007CW-Ta for ged-emacs-devel@m.gmane.org; Thu, 25 Mar 2010 00:14:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NueSl-0007CP-ED for emacs-devel@gnu.org; Thu, 25 Mar 2010 00:14:31 -0400 Original-Received: from [140.186.70.92] (port=38217 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NueSk-0007CH-5t for emacs-devel@gnu.org; Thu, 25 Mar 2010 00:14:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NueSi-0001SB-NA for emacs-devel@gnu.org; Thu, 25 Mar 2010 00:14:30 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:50127) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NueSi-0001S3-CJ for emacs-devel@gnu.org; Thu, 25 Mar 2010 00:14:28 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KZT00900L12G800@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Thu, 25 Mar 2010 06:14:01 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.70.237.109]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KZT0089ML3CU840@a-mtaout20.012.net.il>; Thu, 25 Mar 2010 06:14:01 +0200 (IST) In-reply-to: <87tys5be09.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:122634 Archived-At: > From: Chong Yidong > Cc: Andy Moreton , emacs-devel@gnu.org, > Eli Zaretskii > Date: Wed, 24 Mar 2010 17:34:14 -0400 > > However, looking at that recipe, it seems the problem is actually > handled by my 2009-01-10 (it_method == GET_FROM_DISPLAY_VECTOR) change > instead. So either my 2008-01-26 change was bogus all along, or some > other change in the meantime made it bogus. > > I've reverted it in the branch; thanks for investigating. But the part that you left in the code also uses it.glyph_row, which is garbage after a call to move_it_to. There's a single use of it.glyph_row->x before the call to PRODUCE_GLYPHS (&it2), and I think that needs to be fixed as well, because it potentially dereferences a bad pointer. Or did I miss something?