unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lennart Borgman <lennart.borgman@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: The unwarranted scrolling assumption
Date: Thu, 17 Jun 2010 22:26:40 +0300	[thread overview]
Message-ID: <83fx0lihov.fsf@gnu.org> (raw)
In-Reply-To: <AANLkTinyluu09L7BE8-lz3GbLtJhVBBqzevkNfe-8uk3@mail.gmail.com>

> From: Lennart Borgman <lennart.borgman@gmail.com>
> Date: Thu, 17 Jun 2010 21:14:04 +0200
> Cc: emacs-devel@gnu.org
> 
> >  if (b->clip_changed
> >           && !NILP (w->window_end_valid)
> >           && w->current_matrix->buffer == b
> >           && w->current_matrix->zv == BUF_ZV (b)
> >           && w->current_matrix->begv == BUF_BEGV (b))
> >    b->clip_changed = 0;
> >
> > So, if b->clip_changed is non-zero at entry to reconsider_clip_changes,
> > and w->window_end_valid is non-nil, as you say, this code should have
> > reset b->clip_changed to zero.  And yet you say it didn't.  Why not?
> > what prevented it from doing so?
> 
> I thought so first too, but please see the message I just sent with an
> explanation of the patches I sent.

Sorry, that doesn't explain it to me, because narrowing is not part of
the recipe at all.

Again, PLEASE answer my questions, if you really want my help in
understanding this issue.  What parts of the above condition prevented
reconsider_clip_changes from resetting b->clip_changed to zero?  If
needed, please re-run under GDB (without your patches) and see what
other factors are at work here.




  reply	other threads:[~2010-06-17 19:26 UTC|newest]

Thread overview: 192+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15 20:37 The unwarranted scrolling assumption Lennart Borgman
2010-06-15 21:39 ` Juri Linkov
2010-06-15 22:41   ` Juanma Barranquero
2010-06-15 23:00     ` Lennart Borgman
2010-06-15 23:24       ` Sean Sieger
2010-06-15 23:46         ` Juanma Barranquero
2010-06-15 23:59           ` Lennart Borgman
2010-06-16  0:21             ` Juanma Barranquero
2010-06-16  0:29             ` Chad Brown
2010-06-16  0:39               ` Lennart Borgman
2010-06-16 13:45                 ` Stefan Monnier
2010-06-16  0:55             ` David De La Harpe Golden
2010-06-16  1:40               ` Lennart Borgman
2010-06-16  9:36                 ` Kim F. Storm
2010-06-16 17:35                   ` Lennart Borgman
2010-06-16 21:22                     ` Eli Zaretskii
2010-06-16 22:17                       ` Lennart Borgman
2010-06-17  3:04                         ` Eli Zaretskii
2010-06-17 18:44                         ` Lennart Borgman
2010-06-17 19:08                           ` Eli Zaretskii
2010-06-17 19:14                             ` Lennart Borgman
2010-06-17 19:26                               ` Eli Zaretskii [this message]
2010-06-17 19:35                                 ` Lennart Borgman
2010-06-18  7:39                                   ` Eli Zaretskii
2010-06-18 13:30                                     ` Lennart Borgman
2010-06-18 13:52                                       ` Eli Zaretskii
2010-06-18 14:07                                         ` Lennart Borgman
2010-06-18 14:29                                           ` Eli Zaretskii
2010-06-18 14:37                                             ` Lennart Borgman
2010-06-18 14:58                                               ` Eli Zaretskii
2010-06-18 15:08                                                 ` Lennart Borgman
2010-06-18 15:35                                                   ` Eli Zaretskii
2010-06-18 16:39                                                     ` Lennart Borgman
2010-06-18 17:31                                                       ` Lennart Borgman
2010-06-18 19:00                                                         ` Eli Zaretskii
2010-06-18 21:25                                                           ` Lennart Borgman
2010-06-19  0:18                                                             ` Lennart Borgman
2010-06-19  8:44                                                               ` Eli Zaretskii
2010-06-19 15:41                                                                 ` Lennart Borgman
2010-06-19  8:36                                                             ` Eli Zaretskii
2010-06-19 14:45                                                               ` Lennart Borgman
2010-06-18 15:22                                               ` Stefan Monnier
2010-06-18 15:29                                                 ` Lennart Borgman
2010-06-18 15:36                                                   ` Lennart Borgman
2010-06-17 22:16                                 ` Lennart Borgman
2010-06-17 22:50                                   ` Lennart Borgman
2010-06-17 23:49                                     ` Lennart Borgman
2010-06-17 23:59                                       ` Lennart Borgman
2010-06-18  0:12                                         ` Lennart Borgman
2010-06-18  7:58                                       ` Eli Zaretskii
2010-06-18 13:48                                         ` Lennart Borgman
2010-06-19 13:27                                       ` Eli Zaretskii
2010-06-19 13:36                                         ` Lennart Borgman
2010-06-19 14:10                                           ` Eli Zaretskii
2010-06-19 14:20                                             ` Lennart Borgman
2010-06-19 16:07                                               ` Eli Zaretskii
2010-06-19 17:21                                                 ` Lennart Borgman
2010-06-19 18:02                                                   ` Eli Zaretskii
2010-06-19 18:07                                                     ` Lennart Borgman
2010-06-19 18:31                                                       ` Eli Zaretskii
2010-06-19 19:11                                                         ` Lennart Borgman
2010-06-18  7:54                                   ` Eli Zaretskii
2010-06-18 13:30                                     ` Stefan Monnier
2010-06-18 14:09                                       ` Eli Zaretskii
2010-06-18 14:18                                         ` Lennart Borgman
2010-06-18 15:11                                         ` Stefan Monnier
2010-06-18 15:46                                           ` Eli Zaretskii
2010-06-18 18:30                                             ` Stefan Monnier
2010-06-19  9:51                                               ` Eli Zaretskii
2010-06-19 11:36                                                 ` Eli Zaretskii
2010-06-19 12:54                                                   ` Eli Zaretskii
2010-06-19 13:00                                                     ` Lennart Borgman
2010-06-19 14:03                                                       ` Eli Zaretskii
2010-06-19 14:11                                                         ` Lennart Borgman
2010-06-19 14:16                                                           ` Eli Zaretskii
2010-06-19 14:20                                                             ` Lennart Borgman
2010-06-19 16:05                                                               ` Eli Zaretskii
2010-06-19 17:22                                                                 ` Lennart Borgman
2010-06-19 17:54                                                                   ` Eli Zaretskii
2010-06-19 17:58                                                                     ` Lennart Borgman
2010-06-19 18:30                                                                       ` Eli Zaretskii
2010-06-19 19:10                                                                         ` Lennart Borgman
2010-06-19 21:18                                                                           ` Eli Zaretskii
2010-06-19 21:58                                                                             ` Lennart Borgman
2010-06-20 15:24                                                                               ` Eli Zaretskii
2010-06-20 18:17                                                                                 ` Eli Zaretskii
2010-06-21  1:13                                                                                   ` Lennart Borgman
2010-06-21  2:55                                                                                     ` Eli Zaretskii
2010-06-21  9:31                                                                                       ` Lennart Borgman
2010-06-21  9:59                                                                                         ` Juanma Barranquero
2010-06-21 10:35                                                                                           ` Lennart Borgman
2010-06-21 11:09                                                                                             ` Juanma Barranquero
2010-06-21 11:21                                                                                               ` Lennart Borgman
2010-06-21 11:29                                                                                                 ` Juanma Barranquero
2010-06-21 11:41                                                                                                   ` Lennart Borgman
2010-06-21 11:48                                                                                                     ` Juanma Barranquero
2010-06-21 17:01                                                                                         ` Eli Zaretskii
2010-06-21 17:36                                                                                           ` Lennart Borgman
2010-06-19 20:13                                                                     ` David De La Harpe Golden
2010-06-19 20:26                                                                       ` Lennart Borgman
2010-06-19 20:30                                                                         ` Juanma Barranquero
2010-06-19 20:38                                                                           ` Lennart Borgman
2010-06-19 20:52                                                                             ` Juanma Barranquero
2010-06-19 21:33                                                                             ` Eli Zaretskii
2010-06-19 23:34                                                                               ` Lennart Borgman
2010-06-20 16:54                                                                             ` Stephen J. Turnbull
2010-06-21  1:04                                                                               ` Lennart Borgman
2010-06-21 11:38                                                                                 ` Stephen J. Turnbull
2010-06-21 11:50                                                                                   ` Lennart Borgman
2010-06-21 12:11                                                                                   ` David Engster
2010-06-21 12:23                                                                                     ` Lennart Borgman
2010-06-21 12:45                                                                                       ` David Engster
2010-06-21 14:06                                                                                         ` Lennart Borgman
2010-06-21 16:48                                                                                         ` Eli Zaretskii
2010-06-22  7:48                                                                                           ` David Engster
2010-06-22 17:53                                                                                             ` Eli Zaretskii
2010-06-21 16:55                                                                                     ` Eli Zaretskii
2010-06-19 21:17                                                                       ` Eli Zaretskii
2010-06-19 21:38                                                                         ` Eli Zaretskii
2010-06-19 22:19                                                                           ` David De La Harpe Golden
2010-06-20 18:13                                                                             ` Eli Zaretskii
2010-06-20 21:40                                                                               ` David De La Harpe Golden
2010-06-21  2:59                                                                                 ` Eli Zaretskii
2010-06-21 22:06                                                                                   ` David De La Harpe Golden
2010-06-21 23:04                                                                                     ` Lennart Borgman
2010-06-21 23:50                                                                                       ` David De La Harpe Golden
2010-06-22 18:27                                                                                     ` Eli Zaretskii
2010-06-22 20:22                                                                                       ` David De La Harpe Golden
2010-06-23 19:11                                                                                     ` Eli Zaretskii
2010-06-23 21:11                                                                                       ` David De La Harpe Golden
2010-06-25 15:15                                                                                         ` Eli Zaretskii
2010-06-25 19:42                                                                                           ` David De La Harpe Golden
2010-06-25 21:07                                                                                             ` Eli Zaretskii
2010-06-25 22:28                                                                                               ` David De La Harpe Golden
2010-06-23 22:18                                                                                       ` Stefan Monnier
2010-06-25 10:35                                                                                         ` Eli Zaretskii
2010-06-19 22:16                                                                         ` David De La Harpe Golden
2010-06-19 12:00                                                 ` Eli Zaretskii
2010-06-19 19:13                                                 ` Juanma Barranquero
2010-06-19 21:20                                                   ` Eli Zaretskii
2010-06-19 22:16                                                     ` Juanma Barranquero
2010-06-18 13:45                                     ` Lennart Borgman
2010-06-16 21:23                     ` Eli Zaretskii
2010-06-16 21:31                       ` Lennart Borgman
2010-06-16 21:17                 ` Eli Zaretskii
2010-06-16 21:27                   ` Lennart Borgman
2010-06-17  2:57                     ` Eli Zaretskii
2010-06-17  0:54                   ` Stefan Monnier
2010-06-17  1:17                     ` Lennart Borgman
2010-06-17  3:05                     ` Eli Zaretskii
2010-06-17  3:10                       ` Lennart Borgman
2010-06-17  3:59                         ` Lennart Borgman
2010-06-17  4:55                           ` Lennart Borgman
2010-06-18 13:45                             ` Eli Zaretskii
2010-06-18 13:56                               ` Lennart Borgman
2010-06-18 14:20                                 ` Eli Zaretskii
2010-06-18 14:32                                   ` Lennart Borgman
2010-06-18 15:03                                     ` Eli Zaretskii
2010-06-17 18:25                           ` Eli Zaretskii
2010-06-17 18:32                             ` Lennart Borgman
2010-06-17 18:43                               ` Eli Zaretskii
2010-06-17 19:10                                 ` Lennart Borgman
2010-06-17 19:23                                   ` Eli Zaretskii
2010-06-17 19:31                                     ` Lennart Borgman
2010-06-18  7:36                                       ` Eli Zaretskii
2010-06-18 13:22                                         ` Lennart Borgman
2010-06-17 20:17                                     ` David Engster
2010-06-17 20:39                                       ` Chad Brown
2010-06-17 20:58                                         ` David Engster
2010-06-17 22:30                                       ` Juanma Barranquero
2010-06-17 22:27                                     ` Juanma Barranquero
2010-06-18  8:02                                       ` Eli Zaretskii
2010-06-18 10:15                                         ` Juanma Barranquero
2010-06-18 13:25                                           ` Lennart Borgman
2010-06-18 13:29                                           ` Stefan Monnier
2010-06-18 13:49                                             ` Eli Zaretskii
2010-06-18 15:05                                               ` Stefan Monnier
2010-06-18 15:32                                                 ` Eli Zaretskii
2010-06-18 15:15                                             ` Juanma Barranquero
2010-06-17 19:36                                 ` David Engster
2010-06-17 19:40                                   ` Lennart Borgman
2010-06-18  5:25                                   ` Stefan Monnier
2010-06-16  8:55               ` David Engster
2010-06-15 23:53         ` Lennart Borgman
2010-06-17 20:35         ` Juri Linkov
2010-06-17 22:33           ` Juanma Barranquero
2010-06-18  8:27             ` Juri Linkov
2010-06-18 10:09               ` Juanma Barranquero
  -- strict thread matches above, loose matches on Subject: below --
2010-06-18 19:02 grischka
2010-06-26  3:18 grischka
2010-06-26  5:10 ` David De La Harpe Golden
2010-06-26  8:49   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fx0lihov.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=lennart.borgman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).