From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Buffer size limitation in insdel.c Date: Thu, 23 Sep 2010 16:13:55 +0200 Message-ID: <83fwx0v97g.fsf@gnu.org> References: <834odivv7v.fsf@gnu.org> <83r5gkvqpf.fsf@gnu.org> <83iq1wvep4.fsf@gnu.org> <83hbhgvblq.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1285251251 11300 80.91.229.12 (23 Sep 2010 14:14:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 23 Sep 2010 14:14:11 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 23 16:14:10 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OymYs-0004ga-84 for ged-emacs-devel@m.gmane.org; Thu, 23 Sep 2010 16:14:10 +0200 Original-Received: from localhost ([127.0.0.1]:39977 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OymYr-0007Uj-L9 for ged-emacs-devel@m.gmane.org; Thu, 23 Sep 2010 10:14:09 -0400 Original-Received: from [140.186.70.92] (port=39625 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OymYi-0007TU-1s for emacs-devel@gnu.org; Thu, 23 Sep 2010 10:14:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OymYd-0007bu-5C for emacs-devel@gnu.org; Thu, 23 Sep 2010 10:13:59 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:48769) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OymYc-0007bh-UV for emacs-devel@gnu.org; Thu, 23 Sep 2010 10:13:55 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L9700600E6RZC00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Thu, 23 Sep 2010 16:13:53 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.203.3]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L97006H4E72PU70@a-mtaout22.012.net.il>; Thu, 23 Sep 2010 16:13:53 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130665 Archived-At: > From: Lars Magne Ingebrigtsen > Date: Thu, 23 Sep 2010 15:37:35 +0200 > > Eli Zaretskii writes: > > > And I don't see how you could possibly get it, since > > window_left_edge_col is an int, whereas WINDOW_LEFT_EDGE_COL is > > defined like this: > > > > #define WINDOW_LEFT_EDGE_COL(W) \ > > (XFASTINT ((W)->left_col)) > > > > So it already extracts the integer from a Lisp_Object. What am I > > missing? > > Hm. What version of XFASTINT is being used by default? If it's this > one, I can perhaps understand the warning. I think. > > #define XFASTINT(a) ((a) + 0) Use "gcc -E" to see. In my case, the result is this: matrix->window_left_col = (((((long) ((w)->left_col)) >> (3 - 1)))); which looks correct, unless I'm totally confused. So I think the definition used, at least in my case, is this: #ifndef XFASTINT # define XFASTINT(a) (XINT (a)) because XINT has this definition: # define XINT(a) (((EMACS_INT) (a)) >> (GCTYPEBITS - 1))