From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: it->nglyphs for automatic compositions Date: Tue, 23 Aug 2011 10:07:04 +0300 Message-ID: <83fwksip2f.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1314083235 32372 80.91.229.12 (23 Aug 2011 07:07:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 23 Aug 2011 07:07:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 23 09:07:09 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qvl4m-0002zR-Hm for ged-emacs-devel@m.gmane.org; Tue, 23 Aug 2011 09:07:09 +0200 Original-Received: from localhost ([::1]:49233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qvl4l-0005K0-Nh for ged-emacs-devel@m.gmane.org; Tue, 23 Aug 2011 03:07:07 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:42555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qvl4j-0005Jv-RP for emacs-devel@gnu.org; Tue, 23 Aug 2011 03:07:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qvl4i-0003ku-F3 for emacs-devel@gnu.org; Tue, 23 Aug 2011 03:07:05 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:61428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qvl4i-0003kq-8c for emacs-devel@gnu.org; Tue, 23 Aug 2011 03:07:04 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LQD00400D1NMM00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Tue, 23 Aug 2011 10:07:03 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.126.11.154]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LQD003VED3PNJA0@a-mtaout20.012.net.il>; Tue, 23 Aug 2011 10:07:02 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:143529 Archived-At: > From: Kenichi Handa > Cc: emacs-devel@gnu.org > Date: Tue, 23 Aug 2011 09:35:59 +0900 > > In article <83k4a5idcu.fsf@gnu.org>, Eli Zaretskii writes: > > > Currently, x_produce_glyphs does not set the it->nglyphs member to > > anything, so it stays at zero. This causes pos-visible-in-window-p to > > return incorrect pixel coordinates when invoked on a character that is > > at column zero and is a composed character. Note that > > produce_composite_glyph, which is called only on terminal frames, does > > set that field. So I propose the following patch. > > I agree with that patch. Perhaps I just forgot to set > it->nglyphs when I added this part of the code: > > else if (it->what == IT_COMPOSITION) > { > /* A dynamic (automatic) composition. */ > [...] > } Thanks, committed.