unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kenichi Handa <handa@m17n.org>
Cc: emacs-devel@gnu.org
Subject: Re: it->nglyphs for automatic compositions
Date: Tue, 23 Aug 2011 10:07:04 +0300	[thread overview]
Message-ID: <83fwksip2f.fsf@gnu.org> (raw)
In-Reply-To: <tl739gtotg0.fsf@m17n.org>

> From: Kenichi Handa <handa@m17n.org>
> Cc: emacs-devel@gnu.org
> Date: Tue, 23 Aug 2011 09:35:59 +0900
> 
> In article <83k4a5idcu.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Currently, x_produce_glyphs does not set the it->nglyphs member to
> > anything, so it stays at zero.  This causes pos-visible-in-window-p to
> > return incorrect pixel coordinates when invoked on a character that is
> > at column zero and is a composed character.  Note that
> > produce_composite_glyph, which is called only on terminal frames, does
> > set that field.  So I propose the following patch.
> 
> I agree with that patch.  Perhaps I just forgot to set
> it->nglyphs when I added this part of the code:
> 
>   else if (it->what == IT_COMPOSITION)
>     {
>       /* A dynamic (automatic) composition.  */
> [...]
>     }

Thanks, committed.



      reply	other threads:[~2011-08-23  7:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 17:07 it->nglyphs for automatic compositions Eli Zaretskii
2011-08-23  0:35 ` Kenichi Handa
2011-08-23  7:07   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fwksip2f.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=handa@m17n.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).