From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: The text-mode menu looks very broken in emacs-24 Date: Wed, 18 Jun 2014 21:44:25 +0300 Message-ID: <83fvj2t5va.fsf@gnu.org> References: <87a99amtqk.fsf@fx.delysid.org> <8338f2uw8v.fsf@gnu.org> <87mwda6ph7.fsf@fx.delysid.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1403117095 15542 80.91.229.3 (18 Jun 2014 18:44:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Jun 2014 18:44:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Mario Lang Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 18 20:44:48 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WxKql-0005bc-By for ged-emacs-devel@m.gmane.org; Wed, 18 Jun 2014 20:44:47 +0200 Original-Received: from localhost ([::1]:60036 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxKql-0002Wh-1c for ged-emacs-devel@m.gmane.org; Wed, 18 Jun 2014 14:44:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxKqc-0002SV-8f for emacs-devel@gnu.org; Wed, 18 Jun 2014 14:44:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxKqW-000221-GZ for emacs-devel@gnu.org; Wed, 18 Jun 2014 14:44:38 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:53409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxKqW-00021m-8v for emacs-devel@gnu.org; Wed, 18 Jun 2014 14:44:32 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0N7D00400NUMVN00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Wed, 18 Jun 2014 21:44:30 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N7D004BZO26VG10@a-mtaout20.012.net.il>; Wed, 18 Jun 2014 21:44:30 +0300 (IDT) In-reply-to: <87mwda6ph7.fsf@fx.delysid.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172514 Archived-At: > From: Mario Lang > Date: Wed, 18 Jun 2014 20:29:24 +0200 > > > About 1.5 months ago, you tried the menus with a patch I sent, and > > said that it was "exactly what you was looking for". Did menus work > > OK then, but not now? > > Yes. When I tested the cursor motion changes about 1 1/2 months ago, I > didn't see any display glitches. However, I tested trunk back then, and not > emacs-24, to be exact. Please try the trunk again. The menus code is identical in both branches. Moreover, Dmitry reported bug 17497 for the trunk, not for the release branch. So I don't think this is the reason. > > If so, what, if anything, has changed since then, in terms of your > > system configuration, the way you build Emacs, or the terminal > > emulation software you are using? > > Nothing, except that this time I tried emacs-24. I noticed you reworked > the patch just a few days ago, maybe that introduced the glitches? No, the rework was intended to maybe solve the problems that were reported before the changes I made. > Note that the cursor is placed correctly at the beginning of the menu > item, even if the menu item location is actually incorrect. You mean, the cursor is at the menu item even when that menu item is in the wrong position? IOW, the cursor is also in the wrong position, near the wrongly positioned menu item? > So the cursor motion fix seems "fine", i.e., sync to the display > glitches. Writing the menu item involves moving the cursor to the menu item location first, so if that movement gets the cursor to incorrect position, it will probably do that always.