From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5e43955 1/2: Don't declare vc-exec-after anymore Date: Fri, 23 Oct 2015 10:29:17 +0300 Message-ID: <83fv12rqk2.fsf@gnu.org> References: <20151020190758.14547.6515@vcs.savannah.gnu.org> <5628D1C5.4070300@yandex.ru> <83eggnt054.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1445585377 31628 80.91.229.3 (23 Oct 2015 07:29:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Oct 2015 07:29:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: dgutov@yandex.ru, lekktu@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 23 09:29:26 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZpWmz-0006oa-BQ for ged-emacs-devel@m.gmane.org; Fri, 23 Oct 2015 09:29:25 +0200 Original-Received: from localhost ([::1]:36751 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpWmy-0004cj-7t for ged-emacs-devel@m.gmane.org; Fri, 23 Oct 2015 03:29:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpWmu-0004aj-9P for emacs-devel@gnu.org; Fri, 23 Oct 2015 03:29:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpWmq-0008IR-9G for emacs-devel@gnu.org; Fri, 23 Oct 2015 03:29:20 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:33152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpWmq-0008HZ-0t for emacs-devel@gnu.org; Fri, 23 Oct 2015 03:29:16 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NWN00K00WJLLC00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Fri, 23 Oct 2015 10:29:14 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWN00KGTWSQIS60@a-mtaout21.012.net.il>; Fri, 23 Oct 2015 10:29:14 +0300 (IDT) In-reply-to: <83eggnt054.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192457 Archived-At: > Date: Thu, 22 Oct 2015 18:04:39 +0300 > From: Eli Zaretskii > Cc: lekktu@gmail.com, emacs-devel@gnu.org > > FWIW, on my system I see that warning with all the vc-*.el files that > call vc-run-delayed. The only exception is vc-svn.el, and the reason > is this single line: > > (autoload 'vc-expand-dirs "vc") > > If you remove it, the warning will appear in vc-svn.el as well. > (Loading vc loads vc-dispatcher as a side effect.) > > Another data point: replace this: > > (eval-when-compile (require 'vc)) > > with this: > > (require 'vc) > > and the warning also goes way. So evidently there's some difference > between these two, or maybe a byte-compiler bug. I think bug#21724 supplies an answer: eval-when-compile makes this function known _at_compile_time_, but the warning says it might not be known _at_run_time_. IOW, for a macro it is enough to use eval-when-compile, but if that macro calls a function, the function should be either auto-loaded, or the package that defines that function should be require'd. Does this make sense?