From: Eli Zaretskii <eliz@gnu.org>
To: dgutov@yandex.ru, lekktu@gmail.com
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 5e43955 1/2: Don't declare vc-exec-after anymore
Date: Fri, 23 Oct 2015 10:29:17 +0300 [thread overview]
Message-ID: <83fv12rqk2.fsf@gnu.org> (raw)
In-Reply-To: <83eggnt054.fsf@gnu.org>
> Date: Thu, 22 Oct 2015 18:04:39 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: lekktu@gmail.com, emacs-devel@gnu.org
>
> FWIW, on my system I see that warning with all the vc-*.el files that
> call vc-run-delayed. The only exception is vc-svn.el, and the reason
> is this single line:
>
> (autoload 'vc-expand-dirs "vc")
>
> If you remove it, the warning will appear in vc-svn.el as well.
> (Loading vc loads vc-dispatcher as a side effect.)
>
> Another data point: replace this:
>
> (eval-when-compile (require 'vc))
>
> with this:
>
> (require 'vc)
>
> and the warning also goes way. So evidently there's some difference
> between these two, or maybe a byte-compiler bug.
I think bug#21724 supplies an answer: eval-when-compile makes this
function known _at_compile_time_, but the warning says it might not be
known _at_run_time_.
IOW, for a macro it is enough to use eval-when-compile, but if that
macro calls a function, the function should be either auto-loaded, or
the package that defines that function should be require'd.
Does this make sense?
next prev parent reply other threads:[~2015-10-23 7:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151020190758.14547.6515@vcs.savannah.gnu.org>
[not found] ` <E1ZocGN-0003nd-DB@vcs.savannah.gnu.org>
[not found] ` <CAAeL0STEg9P4GgT_XFJh_J0SexBnoT_Vh_=muMxsQYVBoNW-xA@mail.gmail.com>
2015-10-22 12:08 ` [Emacs-diffs] master 5e43955 1/2: Don't declare vc-exec-after anymore Dmitry Gutov
2015-10-22 12:25 ` Juanma Barranquero
2015-10-22 15:04 ` Eli Zaretskii
2015-10-23 7:29 ` Eli Zaretskii [this message]
2015-10-23 13:38 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fv12rqk2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).