From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Override Windows default Win-* key combinations when using Emacs Date: Tue, 12 Jan 2016 17:54:47 +0200 Message-ID: <83fuy2kd2w.fsf@gnu.org> References: <568BBC58.50702@aprikoodi.fi> <83y4c43qkh.fsf@gnu.org> <5691667C.5000009@aprikoodi.fi> <838u3wkkvb.fsf@gnu.org> <5694E07E.8010005@aprikoodi.fi> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1452614105 15706 80.91.229.3 (12 Jan 2016 15:55:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jan 2016 15:55:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jussi Lahdenniemi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 12 16:55:04 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aJ1Hi-0005Zp-O1 for ged-emacs-devel@m.gmane.org; Tue, 12 Jan 2016 16:55:02 +0100 Original-Received: from localhost ([::1]:32794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ1He-0004jW-Cl for ged-emacs-devel@m.gmane.org; Tue, 12 Jan 2016 10:54:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ1HO-0004jI-OV for emacs-devel@gnu.org; Tue, 12 Jan 2016 10:54:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJ1HK-0001k0-Oe for emacs-devel@gnu.org; Tue, 12 Jan 2016 10:54:42 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ1HK-0001jv-L3; Tue, 12 Jan 2016 10:54:38 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3763 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aJ1HJ-0006to-Vo; Tue, 12 Jan 2016 10:54:38 -0500 In-reply-to: <5694E07E.8010005@aprikoodi.fi> (message from Jussi Lahdenniemi on Tue, 12 Jan 2016 13:16:14 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198080 Archived-At: > From: Jussi Lahdenniemi > Cc: emacs-devel@gnu.org > Date: Tue, 12 Jan 2016 13:16:14 +0200 > > > I've briefly reviewed the rest of the patch, and it looks OK to me. > > Did you make sure the new code doesn't call any API that might be > > unavailable on older systems? We still support Windows 98 and later. > > Unfortunately, Windows 98 does not include the low-level keyboard hook > functionality that is essential for my code to work. It is supported in > Windows 2000 (and even NT4, apparently), but not on the 95/98/ME branch. > > So, probably I would need to change the code so that the old > functionality is preserved and used if the new API are not available > (pre-Win2000), in the same style that w32uniscribe works? Which APIs that you used in the patch are not available on Windows 9X? I thought I went over all of them, and they all are, but maybe I missed some. Most of the examples of how to use an API that might not be available and should be detected at run time are in w32.c, although w32uniscribe.c also does something similar in a few cases. > > Also, I understand that this code will work on versions of Windows > > before v8, is that right? > > I have tested the code on Windows 10 (my physical PC) and Windows 7 (in > a VM) both as 32-bit and 64-bit versions. I'll try to get Win2000 > installed on another VM as well and test with it, just to be sure. If W2K is difficult to get by, XP should be good enough. Thanks.