* Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system [not found] ` <20160610080445.5113D220143@vcs.savannah.gnu.org> @ 2016-06-10 15:54 ` Stefan Monnier 2016-06-13 9:12 ` David Reitter 0 siblings, 1 reply; 4+ messages in thread From: Stefan Monnier @ 2016-06-10 15:54 UTC (permalink / raw) To: emacs-devel; +Cc: David Reitter > ;; Pre-write conversion for `utf-8-hfs'. > (defun ucs-normalize-hfs-nfd-pre-write-conversion (from to) > - (let ((old-buf (current-buffer))) > - (set-buffer (generate-new-buffer " *temp*")) > - (if (stringp from) > - (insert from) > - (insert-buffer-substring old-buf from to)) > - (ucs-normalize-HFS-NFD-region (point-min) (point-max)) > - nil)) > + (ucs-normalize-HFS-NFD-region (point-min) (point-max))) Could you add a comment explaining why it's OK to ignore `from` and `to` here (as well as rename those args to `_from` and `_to` to make it clear to the byte-compiler that we purposefully ignore them)? Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system 2016-06-10 15:54 ` [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system Stefan Monnier @ 2016-06-13 9:12 ` David Reitter 2016-06-13 12:22 ` Stefan Monnier 2016-06-13 14:01 ` Eli Zaretskii 0 siblings, 2 replies; 4+ messages in thread From: David Reitter @ 2016-06-13 9:12 UTC (permalink / raw) To: Stefan Monnier, Eli Zaretskii; +Cc: emacs-devel On Jun 10, 2016, at 11:54 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote: > Could you add a comment explaining why it's OK to ignore `from` and `to` > here (as well as rename those args to `_from` and `_to` to make it > clear to the byte-compiler that we purposefully ignore them)? I could, and I have. Is it okay to commit this bug fix in emacs-25? (Is cherry-picking of the two commits okay for this purpose?) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system 2016-06-13 9:12 ` David Reitter @ 2016-06-13 12:22 ` Stefan Monnier 2016-06-13 14:01 ` Eli Zaretskii 1 sibling, 0 replies; 4+ messages in thread From: Stefan Monnier @ 2016-06-13 12:22 UTC (permalink / raw) To: emacs-devel >> Could you add a comment explaining why it's OK to ignore `from` and `to` >> here (as well as rename those args to `_from` and `_to` to make it >> clear to the byte-compiler that we purposefully ignore them)? > I could, and I have. I saw it. Thanks very much. > Is it okay to commit this bug fix in emacs-25? > (Is cherry-picking of the two commits okay for this purpose?) Sorry, no idea about this, Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system 2016-06-13 9:12 ` David Reitter 2016-06-13 12:22 ` Stefan Monnier @ 2016-06-13 14:01 ` Eli Zaretskii 1 sibling, 0 replies; 4+ messages in thread From: Eli Zaretskii @ 2016-06-13 14:01 UTC (permalink / raw) To: David Reitter; +Cc: monnier, emacs-devel > From: David Reitter <david.reitter@gmail.com> > Date: Mon, 13 Jun 2016 17:12:21 +0800 > Cc: emacs-devel@gnu.org > > On Jun 10, 2016, at 11:54 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote: > > > Could you add a comment explaining why it's OK to ignore `from` and `to` > > here (as well as rename those args to `_from` and `_to` to make it > > clear to the byte-compiler that we purposefully ignore them)? > > I could, and I have. Thanks. > Is it okay to commit this bug fix in emacs-25? I thought we ended up realizing that there was some other factor at work, which caused a simple 'insert' in a temporary buffer trigger tool-bar update, and you were trying to find a simple recipe for reproducing that? I'd like to get to the bottom of that strange phenomenon, because it could just be that the ucs-normalize change is fixing the symptom, not the malady. Did I miss something? ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-13 14:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160610080445.616.81209@vcs.savannah.gnu.org>
[not found] ` <20160610080445.5113D220143@vcs.savannah.gnu.org>
2016-06-10 15:54 ` [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system Stefan Monnier
2016-06-13 9:12 ` David Reitter
2016-06-13 12:22 ` Stefan Monnier
2016-06-13 14:01 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).