unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Clément Pit--Claudel" <clement.pit@gmail.com>
Cc: acm@muc.de, emacs-devel@gnu.org, schwab@suse.de
Subject: Re: What makes set-window-buffer slow?
Date: Sat, 25 Jun 2016 10:30:57 +0300	[thread overview]
Message-ID: <83fus1209a.fsf@gnu.org> (raw)
In-Reply-To: <576DA723.1000603@gmail.com> (message from Clément Pit--Claudel on Fri, 24 Jun 2016 17:33:23 -0400)

> Cc: acm@muc.de, schwab@suse.de, emacs-devel@gnu.org
> From: Clément Pit--Claudel <clement.pit@gmail.com>
> Date: Fri, 24 Jun 2016 17:33:23 -0400
> 
> When started, Proof General splits the screen in two:
> 
> |             |             |
> |             |             |
> | User's file | Message log |
> |             |             |
> |             |             |
> 
> Each time a message is received, it's displayed in the Message log window.
> My extension sometimes reuses that window for other things (for example, to show company-mode's documentation buffer).
> The set-window-buffer call is there to ensure that the user sees new messages. Of course in most cases that call is useless: that's why predicating it on the window not already displaying the message log makes things faster.

Does the WINDOW argument of set-window-buffer name the selected window
at the time of the call?  If not, set-window-buffer will cause all the
other windows to be redisplayed, so arranging for WINDOW to be the
selected window might speed up things.

Another potential speedup might be had if you invoke set-window-buffer
with its KEEP-MARGINS argument non-nil.

Alternatively, try changing your hook to use its own window for
whatever you want to show, leaving the "Message Log" window alone.

I'm puzzled how come redisplay was called so many times (2400) in this
scenario.  Is such a large number reasonable?  How many seconds did it
take to run the scenario?

> > Also, how come it doesn't happen on your machine?  Are any
> > customizations involved?  Is your OS different from that of the other
> > user?
> 
> Somewhat unclear. The OS are the same (Linux mint), and the problem does happen in emacs -Q for the other user. The version of Emacs is the same.

How about local vs remote invocation, and/or the X configuration in
general?

Also, what about toolkits and Cairo -- did both builds use the same
optional features in this department?

Finally, if the user can try a later Emacs, it might help, because
some non-trivial redisplay optimizations were done since 24.4.



  reply	other threads:[~2016-06-25  7:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-23 15:48 What makes set-window-buffer slow? Clément Pit--Claudel
2016-06-23 16:01 ` Andreas Schwab
2016-06-23 17:45   ` Clément Pit--Claudel
2016-06-23 18:12     ` Alan Mackenzie
2016-06-23 18:30       ` Clément Pit--Claudel
2016-06-23 19:11         ` Eli Zaretskii
2016-06-23 21:23           ` Clément Pit--Claudel
2016-06-24  6:54             ` Eli Zaretskii
2016-06-24 12:33               ` Clément Pit--Claudel
2016-06-24 13:56                 ` Eli Zaretskii
2016-06-24 14:19                   ` Clément Pit--Claudel
2016-06-24 18:31                     ` Clément Pit--Claudel
2016-06-24 19:13                     ` Eli Zaretskii
2016-06-24 21:33                       ` Clément Pit--Claudel
2016-06-25  7:30                         ` Eli Zaretskii [this message]
2016-06-25 14:07                           ` Clément Pit--Claudel
2016-06-25 14:27                             ` Eli Zaretskii
2016-06-25 14:39                               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fus1209a.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=acm@muc.de \
    --cc=clement.pit@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).