unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: emacs-devel@gnu.org
Subject: Re: What’s the deal with #if _LIBC and other non-Emacs code?
Date: Tue, 26 Jul 2016 05:34:42 +0300	[thread overview]
Message-ID: <83fuqxt9dp.fsf@gnu.org> (raw)
In-Reply-To: <xa1twpk9iav5.fsf@mina86.com> (message from Michal Nazarewicz on Tue, 26 Jul 2016 00:58:06 +0200)

> From: Michal Nazarewicz <mina86@mina86.com>
> Date: Tue, 26 Jul 2016 00:58:06 +0200
> 
> I’ve noticed quite some code in regex.c and regex.h which isn’t used by
> Emacs or any executable distributed with Emacs.  Most notably, there are
> blocks of code guarded with ‘#ifdef _LIBC’ macro and support for
> alternative syntax which is never actually used.
> 
> To me this all looks like it could be safely removed simplifying and
> shortening the code.
> 
> I would be happy to prepare patches doing just that, but first I’d like
> to make sure that there’s nothing I’m missing.

This code is maintained by glibc, where those parts are used.
Although our version diverged quite a lot from the one in glibc, we
still have plans to merge them at some point.  So I think we shouldn't
remove those parts.

Thanks.



  reply	other threads:[~2016-07-26  2:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 22:58 What’s the deal with #if _LIBC and other non-Emacs code? Michal Nazarewicz
2016-07-26  2:34 ` Eli Zaretskii [this message]
2016-07-26  2:42   ` Stefan Monnier
2016-07-26  6:50     ` Paul Eggert
2016-07-26 14:51     ` Eli Zaretskii
2016-07-26 15:33       ` Stefan Monnier
2016-07-26 15:40         ` Eli Zaretskii
2016-07-26 16:06           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fuqxt9dp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mina86@mina86.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).