From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Dired: Improve symmetry in mark/unmark commands bound to keys Date: Mon, 03 Oct 2016 12:54:02 +0300 Message-ID: <83fuodpxl1.fsf@gnu.org> References: <877fa12iyq.fsf@linux-m68k.org> <83h995ay04.fsf@gnu.org> <87y42h13pi.fsf@linux-m68k.org> <83fuopax4g.fsf@gnu.org> <87twd512pk.fsf@linux-m68k.org> <83bmzacwmk.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-7 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1475488490 24729 195.159.176.226 (3 Oct 2016 09:54:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Oct 2016 09:54:50 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 03 11:54:46 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqzxO-0005yi-7b for ged-emacs-devel@m.gmane.org; Mon, 03 Oct 2016 11:54:46 +0200 Original-Received: from localhost ([::1]:35637 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqzxM-0005BS-R2 for ged-emacs-devel@m.gmane.org; Mon, 03 Oct 2016 05:54:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqzwZ-00059Q-MW for emacs-devel@gnu.org; Mon, 03 Oct 2016 05:53:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqzwU-0001JN-JZ for emacs-devel@gnu.org; Mon, 03 Oct 2016 05:53:54 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqzwU-0001JE-G9; Mon, 03 Oct 2016 05:53:50 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1386 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bqzwT-0005Sw-MW; Mon, 03 Oct 2016 05:53:50 -0400 In-reply-to: (message from Tino Calancha on Mon, 3 Oct 2016 18:21:51 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207952 Archived-At: > From: Tino Calancha > Date: Mon, 3 Oct 2016 18:21:51 +0900 (JST) > cc: Tino Calancha , schwab@linux-m68k.org, > drew.adams@oracle.com, Emacs developers > > > FWIW, I'm okay with this. > > > >> I mean, we should not invert the number of C-u's in I) II) > > > > Indeed, no need. > > > > Thanks. > Thank you Eli. I propose following patch: Thanks, I have a couple of minor comments below. > * doc/misc/dired-x.texi: Update documentation for 'dired-mark-extension'. This part of the log entry should state in parentheses the node in which the change is being made, as if the node were a function. > is not automatically prepended to the string entered, you must type it > -explicitly. If invoked with a prefix argument, this command asks for > -a character to use as the marker. > +explicitly. > +If invoked with prefix argument @kbd{C-u}, this command unmark files instead. > +Calling it with the @kbd{C-u C-u} prefix, asks for a character to use ^^^^^^^^^^ "If called" sounds better and more correct English-wise. > +as the marker, and mark files with it. ^^^^ "marks" > +Prefixed with two C-u¢s, prompt for MARKER-CHAR and mark files with it." ^ Please use the ASCII apostrophe character ' here, not ¢, so that the user could control the result via text-quoting-style. With the above gotchas fixed, this is okay for the master branch.