From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Dired: Improve symmetry in mark/unmark commands bound to keys
Date: Mon, 03 Oct 2016 12:54:02 +0300 [thread overview]
Message-ID: <83fuodpxl1.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1610031820240.16224@calancha-pc> (message from Tino Calancha on Mon, 3 Oct 2016 18:21:51 +0900 (JST))
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Mon, 3 Oct 2016 18:21:51 +0900 (JST)
> cc: Tino Calancha <tino.calancha@gmail.com>, schwab@linux-m68k.org,
> drew.adams@oracle.com, Emacs developers <emacs-devel@gnu.org>
>
> > FWIW, I'm okay with this.
> >
> >> I mean, we should not invert the number of C-u's in I) II)
> >
> > Indeed, no need.
> >
> > Thanks.
> Thank you Eli. I propose following patch:
Thanks, I have a couple of minor comments below.
> * doc/misc/dired-x.texi: Update documentation for 'dired-mark-extension'.
This part of the log entry should state in parentheses the node in
which the change is being made, as if the node were a function.
> is not automatically prepended to the string entered, you must type it
> -explicitly. If invoked with a prefix argument, this command asks for
> -a character to use as the marker.
> +explicitly.
> +If invoked with prefix argument @kbd{C-u}, this command unmark files instead.
> +Calling it with the @kbd{C-u C-u} prefix, asks for a character to use
^^^^^^^^^^
"If called" sounds better and more correct English-wise.
> +as the marker, and mark files with it.
^^^^
"marks"
> +Prefixed with two C-u’s, prompt for MARKER-CHAR and mark files with it."
^
Please use the ASCII apostrophe character ' here, not ’, so that the
user could control the result via text-quoting-style.
With the above gotchas fixed, this is okay for the master branch.
next prev parent reply other threads:[~2016-10-03 9:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 17:31 Dired: Improve symmetry in mark/unmark commands bound to keys Tino Calancha
2016-09-24 18:12 ` Eli Zaretskii
2016-09-24 18:25 ` Tino Calancha
2016-09-24 19:31 ` Andreas Schwab
2016-09-24 19:39 ` Eli Zaretskii
2016-09-24 19:46 ` Andreas Schwab
2016-09-24 19:58 ` Eli Zaretskii
2016-09-24 20:07 ` Andreas Schwab
2016-09-24 23:49 ` Drew Adams
2016-09-25 9:06 ` Tino Calancha
2016-09-25 18:55 ` John Wiegley
2016-09-26 9:23 ` Tino Calancha
2016-09-26 11:05 ` Tino Calancha
2016-09-26 15:02 ` Eli Zaretskii
2016-09-26 15:06 ` Eli Zaretskii
2016-09-26 15:47 ` John Wiegley
2016-09-26 16:30 ` Tino Calancha
2016-09-26 19:02 ` Eli Zaretskii
2016-10-03 9:21 ` Tino Calancha
2016-10-03 9:54 ` Eli Zaretskii [this message]
2016-10-03 11:15 ` Tino Calancha
2016-09-26 21:52 ` John Wiegley
2016-09-25 19:14 ` Eli Zaretskii
2016-09-25 22:43 ` Andreas Schwab
2016-09-25 22:58 ` Andreas Schwab
2016-09-25 23:00 ` Andreas Schwab
2016-09-26 2:38 ` Eli Zaretskii
2016-09-26 8:33 ` Andreas Schwab
2016-09-26 14:59 ` Eli Zaretskii
2016-09-24 19:49 ` Tino Calancha
[not found] <<alpine.DEB.2.20.1609250230400.4103@calancha-pc>
[not found] ` <<83oa3db20a.fsf@gnu.org>
2016-09-24 18:53 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fuodpxl1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).