From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: jschwab@gmail.com, emacs-devel@gnu.org
Subject: Re: Bugs related to buffer-local tags-file-name
Date: Thu, 01 Dec 2016 18:53:48 +0200 [thread overview]
Message-ID: <83fum7pp43.fsf@gnu.org> (raw)
In-Reply-To: <e3df930b-c872-ebd4-dd67-b1cd6f8021ba@yandex.ru> (message from Dmitry Gutov on Wed, 30 Nov 2016 03:12:20 +0200)
close 158
close 17326
close 23164
close 19741
thanks
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Wed, 30 Nov 2016 03:12:20 +0200
>
> On 29.11.2016 19:25, Eli Zaretskii wrote:
>
> > Dmitry, should I wait for your testing as well, or should I just push
> > the changes?
>
> Yes, sorry. I think you should go ahead with them, maybe with some minor
> tweaks.
Done.
> - In visit-tags-table-buffer's docstring, "optional arg CONT" should
> probably be just "CONT", all three times.
Fixed.
> - More importantly, this patch contains a backward-incompatible change
> to the tags-completion-table function. Maybe we should consider how to
> make BUF an optional argument.
It is optional now.
> - It would be great if let-binding tags-table-list around
> tags-lazy-completion-table didn't leak it to the global value either
> (which happens with company-etags). Alas, this seems to be a harder task.
Right, patches welcome.
next prev parent reply other threads:[~2016-12-01 16:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 18:53 Bugs related to buffer-local tags-file-name Josiah Schwab
2016-11-23 0:04 ` Dmitry Gutov
2016-11-23 1:54 ` Josiah Schwab
2016-11-24 17:34 ` Eli Zaretskii
2016-11-24 22:10 ` Dmitry Gutov
2016-11-25 7:38 ` Eli Zaretskii
2016-11-26 11:46 ` Eli Zaretskii
2016-11-26 17:39 ` Josiah Schwab
2016-11-26 18:18 ` Eli Zaretskii
2016-11-29 17:25 ` Eli Zaretskii
2016-11-29 18:33 ` Josiah Schwab
2016-11-29 18:55 ` Eli Zaretskii
2016-11-30 1:12 ` Dmitry Gutov
2016-12-01 16:53 ` Eli Zaretskii [this message]
2016-12-01 23:29 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fum7pp43.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=jschwab@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).