unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jean-Christophe Helary <jean.christophe.helary@gmail.com>
Cc: npostavs@gmail.com, emacs-devel@gnu.org
Subject: Re: package.el strings
Date: Sun, 17 Jun 2018 17:33:19 +0300	[thread overview]
Message-ID: <83fu1ltrdc.fsf@gnu.org> (raw)
In-Reply-To: <CA7C80A9-AC70-4BB8-9BCA-612C6650D760@gmail.com> (message from Jean-Christophe Helary on Sun, 17 Jun 2018 23:02:08 +0900)

> From: Jean-Christophe Helary <jean.christophe.helary@gmail.com>
> Date: Sun, 17 Jun 2018 23:02:08 +0900
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> There is indeed another change I want to make but that can wait. It involves removing some of the text decorations to be able to straighten some strings.
> 
> If there is an agreement to proceed I can do that later. In the meanwhile it would be nice if you could first commit the biggest part of the modifications.

Thanks, but there are a couple of hunks I don't understand:

>  (defcustom package-archives `(("gnu" .
> -                               ,(format "http%s://elpa.gnu.org/packages/"
> -                                        (if (gnutls-available-p) "s" ""))))
> +                               ,(let ((https "https://elpa.gnu.org/packages/")
> +                                      (http   "http://elpa.gnu.org/packages/"))
> +                                  (if (gnutls-available-p) https http))))
> +

Why did you need this change?

> -           (dir (expand-file-name (format "archives/%s" name) package-user-dir))
> +           (dir (expand-file-name (concat "archives/" name) package-user-dir))

Same question here.
> -        (message "No packages to upgrade.")
> +        (message "No packages to upgrade")

I think our style is not to include a period in messages.



  reply	other threads:[~2018-06-17 14:33 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-24  5:08 package.el strings Jean-Christophe Helary
2017-05-24 11:00 ` Jean-Christophe Helary
2017-05-24 12:04 ` Dmitry Gutov
2017-05-24 12:07   ` Jean-Christophe Helary
2017-05-24 12:36   ` Yuri Khan
2017-05-24 14:16   ` Richard Stallman
2017-07-14  2:53 ` Jean-Christophe Helary
2017-07-15 12:52   ` Eli Zaretskii
2017-07-15 14:48     ` Jean-Christophe Helary
2017-07-16 13:55       ` Jean-Christophe Helary
2017-07-16 14:16         ` Eli Zaretskii
2017-07-16 14:35       ` Eli Zaretskii
2017-07-16 14:37         ` Jean-Christophe Helary
2017-07-17 15:28       ` Jean-Christophe Helary
2017-07-22  9:23         ` Eli Zaretskii
2018-04-18  6:38           ` Jean-Christophe Helary
2018-04-26  1:10             ` Noam Postavsky
2018-04-26  6:31               ` Jean-Christophe Helary
2018-04-26 11:28                 ` Noam Postavsky
2018-04-26 13:32                   ` Jean-Christophe Helary
2018-04-28 22:11                     ` Noam Postavsky
2018-04-28 23:46                       ` Jean-Christophe Helary
2018-05-29 22:38                         ` Noam Postavsky
2018-05-29 22:46                           ` Jean-Christophe Helary
2018-06-17 14:02                           ` Jean-Christophe Helary
2018-06-17 14:33                             ` Eli Zaretskii [this message]
2018-06-17 14:45                               ` Jean-Christophe Helary
2018-06-17 14:50                                 ` Eli Zaretskii
2018-06-17 14:58                                   ` Jean-Christophe Helary
2018-06-20 13:53                                     ` Jean-Christophe Helary
2018-06-20 15:54                                       ` Eli Zaretskii
2018-06-20 16:19                                         ` Jean-Christophe Helary
2018-06-24 15:37                                           ` Noam Postavsky
2018-06-24 21:57                                             ` Jean-Christophe Helary
2018-06-24 23:09                                               ` Noam Postavsky
2018-06-25  1:39                                                 ` Jean-Christophe Helary
2018-06-25 23:22                                                   ` Noam Postavsky
2018-06-27  4:21                                                     ` Jean-Christophe Helary
2018-06-27 18:32                                                       ` Noam Postavsky
2018-04-29 19:43                       ` Stefan Monnier
2018-04-26 13:40               ` Jean-Christophe Helary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fu1ltrdc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jean.christophe.helary@gmail.com \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).